AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fixed evaluation order issue in defineProperties.

Browse Source 
This is not covered by test262 yet, but it really makes sense and matches Firefox's behaviour.

TEST=mjsunit/define-properties.js
Review URL: http://codereview.chromium.org/8349031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
svenpanne@chromium.org 2011-10-19 09:52:08 +00:00
parent b3eba9e764
commit d0fe04447e
2 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/v8natives.js
View File

@ -1078,10 +1078,12 @@ function ObjectDefineProperties(obj, properties) {
throw MakeTypeError("obj_ctor_property_non_object", ["defineProperties"]);
var props = ToObject(properties);
var names = GetOwnEnumerablePropertyNames(props);
var descriptors = new InternalArray();
for (var i = 0; i < names.length; i++) {
var name = names[i];
var desc = ToPropertyDescriptor(props[name]);
DefineOwnProperty(obj, name, desc, true);
descriptors.push(ToPropertyDescriptor(props[names[i]]));
}
for (var i = 0; i < names.length; i++) {
DefineOwnProperty(obj, names[i], descriptors[i], true);
}
return obj;
}

16
test/mjsunit/object-define-properties.js
View File

@ -54,3 +54,19 @@ var x = Object.defineProperties(obj, desc);
assertEquals(x.foo, 10);
assertEquals(x.bar, 42);
// Make sure that all property descriptors are calculated before any
// modifications are done.
var object = {};
assertThrows(function() {
Object.defineProperties(object, {
foo: { value: 1 },
bar: { value: 2, get: function() { return 3; } }
});
}, TypeError);
assertEquals(undefined, object.foo);
assertEquals(undefined, object.bar);