AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[maglev] Set --maglev-inlining as experimental"

Browse Source 
This reverts commit 2be76fca4b.

Reason for revert: Breaking flag implications: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20no-concurrent-marking/13134/overview

Original change's description:
> [maglev] Set --maglev-inlining as experimental
>
> Bug: v8:7700
> Change-Id: Ida08a24e91149cbc895eb7328774a1154a2e15db
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4218741
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Auto-Submit: Victor Gomes <victorgomes@chromium.org>
> Commit-Queue: Victor Gomes <victorgomes@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#85678}

Bug: v8:7700
Change-Id: I4c88530a76cc73109bc921152d786f3db031790d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4224452
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#85682}
This commit is contained in:
Leszek Swirski 2023-02-06 14:15:36 +00:00 committed by V8 LUCI CQ
parent 95b7d03067
commit d12417f875
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/flags/flag-definitions.h
View File

@ -482,8 +482,8 @@ DEFINE_BOOL(lower_tier_as_toptier, false,
#define V8_ENABLE_MAGLEV_BOOL true #define V8_ENABLE_MAGLEV_BOOL true
DEFINE_BOOL(maglev, false, "enable the maglev optimizing compiler") DEFINE_BOOL(maglev, false, "enable the maglev optimizing compiler")
DEFINE_WEAK_IMPLICATION(future, maglev) DEFINE_WEAK_IMPLICATION(future, maglev)
DEFINE_EXPERIMENTAL_FEATURE(maglev_inlining, DEFINE_BOOL(maglev_inlining, false,
"enable inlining in the maglev optimizing compiler") "enable inlining in the maglev optimizing compiler")
DEFINE_BOOL(maglev_reuse_stack_slots, true, DEFINE_BOOL(maglev_reuse_stack_slots, true,
"reuse stack slots in the maglev optimizing compiler") "reuse stack slots in the maglev optimizing compiler")

1
tools/testrunner/local/variants.py
View File

@ -70,7 +70,6 @@ kIncompatibleFlagsForNoTurbofan = [
# variant. This depends on the flags specified in ALL_VARIANT_FLAGS and on the # variant. This depends on the flags specified in ALL_VARIANT_FLAGS and on the
# implications defined in flag-definitions.h. # implications defined in flag-definitions.h.
INCOMPATIBLE_FLAGS_PER_VARIANT = { INCOMPATIBLE_FLAGS_PER_VARIANT = {
"future": ["--experimental", "--maglev-inlining"],
"jitless": "jitless":
kIncompatibleFlagsForNoTurbofan + [ kIncompatibleFlagsForNoTurbofan + [
"--track-field-types", "--sparkplug", "--concurrent-sparkplug", "--track-field-types", "--sparkplug", "--concurrent-sparkplug",