AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Further tune MapInference in ReduceCallApiFunction

Browse Source 
If speculation is disallowed, this change lets us still do the
optimization if (a) the maps were already reliable or
(b) we are able to take stability dependencies.

Bug: v8:8820
Change-Id: I08340fc19ac87b80aa2b7ed77753dd642e89804f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617663
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61634}
This commit is contained in:
Georg Neis 2019-05-17 14:36:17 +02:00 committed by Commit Bot
parent 20d90b769b
commit d1d61ea8c5
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/compiler/js-call-reducer.cc
View File

@ -2803,9 +2803,10 @@ Reduction JSCallReducer::ReduceCallApiFunction(
if (!api_holder.is_identical_to(holderi)) return inference.NoChange();
}
// We may need to check {receiver_maps} again below, so better
// make sure we are allowed to speculate in this case.
if (p.speculation_mode() == SpeculationMode::kDisallowSpeculation) {
if (p.speculation_mode() == SpeculationMode::kDisallowSpeculation &&
!inference.RelyOnMapsViaStability(dependencies())) {
// We were not able to make the receiver maps reliable without map checks
// but doing map checks would lead to deopt loops, so give up.
return inference.NoChange();
}