diff --git a/BUILD.bazel b/BUILD.bazel index 0bef9acb6e..7f7441ab55 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -2588,7 +2588,6 @@ filegroup( name = "icu/v8_base_without_compiler_files", srcs = [ "src/builtins/builtins-intl.cc", - "src/builtins/builtins-intl-gen.cc", "src/objects/intl-objects.cc", "src/objects/intl-objects.h", "src/objects/js-break-iterator.cc", @@ -3016,7 +3015,7 @@ filegroup( ) filegroup( - name = "v8_initializers_files", + name = "noicu/v8_initializers_files", srcs = [ "src/builtins/builtins-array-gen.cc", "src/builtins/builtins-array-gen.h", @@ -3108,6 +3107,14 @@ filegroup( }), ) +filegroup( + name = "icu/v8_initializers_files", + srcs = [ + "src/builtins/builtins-intl-gen.cc", + ":noicu/v8_initializers_files", + ], +) + filegroup( name = "cppgc_base_files", srcs = [ @@ -3813,7 +3820,6 @@ v8_binary( name = "mksnapshot", srcs = [ ":mksnapshot_files", - ":v8_initializers_files", ] + select({ ":is_not_v8_enable_turbofan": [ # Turbofan is needed to generate builtins. @@ -3829,10 +3835,12 @@ v8_binary( }), icu_srcs = [ ":icu/generated_torque_initializers", + ":icu/v8_initializers_files", ], noicu_deps = [":v8_libshared_noicu"], noicu_srcs = [ ":noicu/generated_torque_initializers", + ":noicu/v8_initializers_files", ], ) diff --git a/bazel/defs.bzl b/bazel/defs.bzl index 9cf723502f..a23646ea37 100644 --- a/bazel/defs.bzl +++ b/bazel/defs.bzl @@ -317,7 +317,7 @@ def _torque_initializers_impl(ctx): # Generate/declare output files outs = [] for src in ctx.files.srcs: - root, period, ext = src.path.rpartition(".") + root, _period, _ext = src.path.rpartition(".") # Strip v8root if root[:len(v8root)] == v8root: @@ -397,7 +397,7 @@ def _torque_definitions_impl(ctx): # Generate/declare output files outs = [] for src in ctx.files.srcs: - root, period, ext = src.path.rpartition(".") + root, _period, _ext = src.path.rpartition(".") # Strip v8root if root[:len(v8root)] == v8root: