AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert of Debugger: correctly redirect eval code. (patchset #2 id:20001 of https://codereview.chromium.org/1258583002/)

Browse Source 
Reason for revert:
Causes hang: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20novfp3/builds/1446

Original issue's description:
> Debugger: correctly redirect eval code.
>
> This also allows us to not always compile for debugging when debug is active.
>
> Committed: https://crrev.com/0cae607ff33725e868a217556a88ac4478774210
> Cr-Commit-Position: refs/heads/master@{#29848}

TBR=mvstanton@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1261603002

Cr-Commit-Position: refs/heads/master@{#29862}
This commit is contained in:
yangguo 2015-07-27 01:05:49 -07:00 committed by Commit bot
parent 567806c787
commit d2b4133c72
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler.cc
View File

@ -112,6 +112,7 @@ CompilationInfo::CompilationInfo(ParseInfo* parse_info)
// with deoptimization support. // with deoptimization support.
if (isolate_->serializer_enabled()) EnableDeoptimizationSupport(); if (isolate_->serializer_enabled()) EnableDeoptimizationSupport();
if (isolate_->debug()->is_active()) MarkAsDebug();
if (FLAG_context_specialization) MarkAsContextSpecializing(); if (FLAG_context_specialization) MarkAsContextSpecializing();
if (FLAG_turbo_inlining) MarkAsInliningEnabled(); if (FLAG_turbo_inlining) MarkAsInliningEnabled();
if (FLAG_turbo_source_positions) MarkAsSourcePositionsEnabled(); if (FLAG_turbo_source_positions) MarkAsSourcePositionsEnabled();
@ -1158,7 +1159,8 @@ MaybeHandle<JSFunction> Compiler::GetFunctionFromEval(
parse_info.set_parse_restriction(restriction); parse_info.set_parse_restriction(restriction);
parse_info.set_context(context); parse_info.set_context(context);
info.MarkAsDebug(); // If we eval from debug code, compile for debugging as well.
if (outer_info->HasDebugCode()) info.MarkAsDebug();
Debug::RecordEvalCaller(script); Debug::RecordEvalCaller(script);
shared_info = CompileToplevel(&info); shared_info = CompileToplevel(&info);