AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Reland "[wasm] Reenable code logging"

Browse Source 
This is a reland of 84d6864a62.
Timeout fixed by any of https://crrev.com/c/1454484 or updated chromium
lkgr.

Original change's description:
> [wasm] Reenable code logging
>
> Code logging was fixed in https://crrev.com/c/1454598. Reenable it.
>
> R=mstarzinger@chromium.org
> CC=herhut@chromium.org
>
> Bug: v8:8783
> Change-Id: I50773d4b42ce52e8d078e47a797ab517771c2756
> Reviewed-on: https://chromium-review.googlesource.com/c/1454601
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59394}

Tbr: mstarzinger@chromium.org
Bug: v8:8783
Change-Id: Ib6a7c079a73f90fbeeade17ef186742d2d30e0d3
Reviewed-on: https://chromium-review.googlesource.com/c/1456105
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59412}
This commit is contained in:
Clemens Hammacher 2019-02-06 12:17:25 +01:00 committed by Commit Bot
parent d7def9003d
commit d472bfb56e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/wasm/module-compiler.cc
View File

@ -1568,8 +1568,7 @@ void CompilationStateImpl::OnFinishedUnit(ExecutionTier tier, WasmCode* code) {
}
}
// TODO(clemensh): Fix and reenable code logging (https://crbug.com/v8/8783).
// if (code != nullptr) native_module_->engine()->LogCode(code);
if (code != nullptr) native_module_->engine()->LogCode(code);
}
void CompilationStateImpl::RestartBackgroundCompileTask() {