From d4c751cb29164ab6c67e9bd36dc934c9ccfa4860 Mon Sep 17 00:00:00 2001 From: Ma Aiguo Date: Wed, 24 Nov 2021 14:47:49 +0800 Subject: [PATCH] [cppgc][unittests] Only expect guard pages support on 4k platforms. Loong64 supports 4K-64K OS pages Fix loong64 unittests PlatformUsesGuardPages failure Change-Id: I1451685828ef1d857b7d2af3f1810286f84bdc50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3299672 Reviewed-by: Zhao Jiazhong Reviewed-by: Michael Lippautz Commit-Queue: Zhao Jiazhong Cr-Commit-Position: refs/heads/main@{#78120} --- AUTHORS | 1 + test/unittests/heap/cppgc/page-memory-unittest.cc | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index 46dd9fb1aa..b89eacba9f 100644 --- a/AUTHORS +++ b/AUTHORS @@ -149,6 +149,7 @@ Loo Rong Jie Lu Yahan Luis Reis Luke Zarko +Ma Aiguo Maciej Małecki Marcel Laverdet Marcin Cieślak diff --git a/test/unittests/heap/cppgc/page-memory-unittest.cc b/test/unittests/heap/cppgc/page-memory-unittest.cc index 8b634113b4..d1c257b463 100644 --- a/test/unittests/heap/cppgc/page-memory-unittest.cc +++ b/test/unittests/heap/cppgc/page-memory-unittest.cc @@ -121,7 +121,7 @@ TEST(PageMemoryRegionTest, PlatformUsesGuardPages) { v8::base::PageAllocator allocator; #if defined(V8_HOST_ARCH_PPC64) && !defined(_AIX) EXPECT_FALSE(SupportsCommittingGuardPages(allocator)); -#elif defined(V8_HOST_ARCH_ARM64) +#elif defined(V8_HOST_ARCH_ARM64) || defined(V8_HOST_ARCH_LOONG64) if (allocator.CommitPageSize() == 4096) { EXPECT_TRUE(SupportsCommittingGuardPages(allocator)); } else {