From d4dd9cd68bd489c6c28e753fad5270e1d3632b80 Mon Sep 17 00:00:00 2001 From: Jochen Eisinger Date: Thu, 20 Jan 2022 09:44:44 +0000 Subject: [PATCH] Reassign some old TODOs to folks currently working on the respective code Change-Id: I8fd11742c4ea13cfd5cd3864e167785b97f1383a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404274 Reviewed-by: Toon Verwaest Commit-Queue: Jochen Eisinger Cr-Commit-Position: refs/heads/main@{#78695} --- BUILD.gn | 12 ++++++------ src/api/api.cc | 2 +- src/builtins/builtins.cc | 2 +- src/d8/d8.cc | 3 ++- src/objects/objects.cc | 2 +- test/intl/intl.status | 2 +- 6 files changed, 12 insertions(+), 11 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 32f7b5c8f0..fb7fc4e909 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -1004,7 +1004,7 @@ config("toolchain") { ] } - # TODO(jochen): Add support for arm_test_noprobe. + # TODO(infra): Add support for arm_test_noprobe. if (current_cpu != "arm") { # These defines ares used for the ARM simulator. @@ -1072,7 +1072,7 @@ config("toolchain") { defines += [ "FPU_MODE_FP32" ] } - # TODO(jochen): Add support for mips_arch_variant rx and loongson. + # TODO(infra): Add support for mips_arch_variant rx and loongson. } if (v8_current_cpu == "mips64el" || v8_current_cpu == "mips64") { @@ -1200,8 +1200,8 @@ config("toolchain") { defines += [ "V8_TARGET_OS_WIN" ] } - # TODO(jochen): Support v8_enable_prof on Windows. - # TODO(jochen): Add support for compiling with simulators. + # TODO(infra): Support v8_enable_prof on Windows. + # TODO(infra): Add support for compiling with simulators. if (v8_enable_debugging_features) { if ((is_linux || is_chromeos) && v8_enable_backtrace) { @@ -5175,7 +5175,7 @@ v8_component("v8_libbase") { "src/base/platform/platform-macos.cc", ] } else if (is_win) { - # TODO(jochen): Add support for cygwin. + # TODO(infra): Add support for cygwin. sources += [ "src/base/debug/stack_trace_win.cc", "src/base/platform/platform-win32.cc", @@ -5224,7 +5224,7 @@ v8_component("v8_libbase") { [ "//build/config/clang:llvm-symbolizer_data($host_toolchain)" ] } - # TODO(jochen): Add support for qnx, freebsd, openbsd, netbsd, and solaris. + # TODO(infra): Add support for qnx, freebsd, openbsd, netbsd, and solaris. } v8_component("v8_libplatform") { diff --git a/src/api/api.cc b/src/api/api.cc index ff8febe4ae..5e49882331 100644 --- a/src/api/api.cc +++ b/src/api/api.cc @@ -8705,7 +8705,7 @@ void Isolate::Initialize(Isolate* isolate, params.experimental_attach_to_shared_isolate)); } - // TODO(jochen): Once we got rid of Isolate::Current(), we can remove this. + // TODO(v8:2487): Once we got rid of Isolate::Current(), we can remove this. Isolate::Scope isolate_scope(isolate); if (i_isolate->snapshot_blob() == nullptr) { FATAL( diff --git a/src/builtins/builtins.cc b/src/builtins/builtins.cc index 2104411b98..c0ab3bc564 100644 --- a/src/builtins/builtins.cc +++ b/src/builtins/builtins.cc @@ -476,7 +476,7 @@ bool Builtins::AllowDynamicFunction(Isolate* isolate, Handle target, if (FLAG_allow_unsafe_function_constructor) return true; HandleScopeImplementer* impl = isolate->handle_scope_implementer(); Handle responsible_context = impl->LastEnteredOrMicrotaskContext(); - // TODO(jochen): Remove this. + // TODO(verwaest): Remove this. if (responsible_context.is_null()) { return true; } diff --git a/src/d8/d8.cc b/src/d8/d8.cc index e47f0d44a7..89d44cd69d 100644 --- a/src/d8/d8.cc +++ b/src/d8/d8.cc @@ -4318,7 +4318,8 @@ bool Shell::SetOptions(int argc, char* argv[]) { argv[i] = nullptr; } else if (strcmp(argv[i], "--invoke-weak-callbacks") == 0) { options.invoke_weak_callbacks = true; - // TODO(jochen) See issue 3351 + // TODO(v8:3351): Invoking weak callbacks does not always collect all + // available garbage. options.send_idle_notification = true; argv[i] = nullptr; } else if (strcmp(argv[i], "--omit-quit") == 0) { diff --git a/src/objects/objects.cc b/src/objects/objects.cc index 05433226be..1df89d2593 100644 --- a/src/objects/objects.cc +++ b/src/objects/objects.cc @@ -6301,7 +6301,7 @@ Handle ObjectHashTableBase::Put(Isolate* isolate, } // Rehash if more than 33% of the entries are deleted entries. - // TODO(jochen): Consider to shrink the fixed array in place. + // TODO(verwaest): Consider to shrink the fixed array in place. if ((table->NumberOfDeletedElements() << 1) > table->NumberOfElements()) { table->Rehash(isolate); } diff --git a/test/intl/intl.status b/test/intl/intl.status index 4350e57bca..3304965438 100644 --- a/test/intl/intl.status +++ b/test/intl/intl.status @@ -28,7 +28,7 @@ [ ################################################################################ [ALWAYS, { -# TODO(jochen): The following test is flaky. +# TODO(ftang,jshin): The following test is flaky. 'overrides/caching': [PASS, FAIL], }], # ALWAYS