AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Reland "[maglev] Test maglev on Mac Arm64 bots""

Browse Source 
This reverts commit b791f4f040.

Reason for revert: Nope, still not yet: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20debug/10154/overview

Original change's description:
> Reland "[maglev] Test maglev on Mac Arm64 bots"
>
> This is a reland of c6e96cf622
>
> Various bugs have been fixed since the revert and we're ready to try
> again.
>
> Original change's description:
> > [maglev] Test maglev on Mac Arm64 bots
> >
> > Also remove unnecessary maglev runs on x64 FYI bots, since maglev runs
> > on the main waterfall's x64 bots already.
> >
> > Bug: v8:7700
> > Change-Id: I5bb23c3ba7696b48f2fe1af4036a3de8c5b1801a
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4128092
> > Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#85174}
>
> Bug: v8:7700
> Change-Id: I969e6ae7bd01adb12da0f1240e152232cca00f33
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4156056
> Auto-Submit: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
> Commit-Queue: Alexander Schulze <alexschulze@chromium.org>
> Reviewed-by: Victor Gomes <victorgomes@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#85275}

Bug: v8:7700
Change-Id: I39ff626e799511d79665b4a9e9fb0f8ef7ae1b7f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4164679
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85277}
This commit is contained in:
Leszek Swirski 2023-01-13 10:18:04 +00:00 committed by V8 LUCI CQ
parent 651d4d9748
commit d53540be77
2 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
BUILD.gn
View File

@ -458,8 +458,7 @@ if (v8_enable_external_code_space == "") {
(target_os != "fuchsia" && v8_current_cpu == "arm64")) (target_os != "fuchsia" && v8_current_cpu == "arm64"))
} }
if (v8_enable_maglev == "") { if (v8_enable_maglev == "") {
v8_enable_maglev = v8_enable_turbofan && v8_enable_maglev = v8_enable_turbofan && v8_current_cpu == "x64" &&
(v8_current_cpu == "x64" || v8_current_cpu == "arm64") &&
v8_enable_pointer_compression v8_enable_pointer_compression
} }
assert(v8_enable_turbofan || !v8_enable_maglev, assert(v8_enable_turbofan || !v8_enable_maglev,

16
infra/testing/builders.pyl
View File

@ -470,6 +470,8 @@
{'name': 'webkit', 'variant': 'stress_sampling'}, {'name': 'webkit', 'variant': 'stress_sampling'},
# Stress snapshot. # Stress snapshot.
{'name': 'mjsunit', 'variant': 'stress_snapshot'}, {'name': 'mjsunit', 'variant': 'stress_snapshot'},
# Maglev.
{'name': 'mjsunit', 'variant': 'maglev'},
# Stress maglev. # Stress maglev.
{'name': 'mjsunit', 'variant': 'stress_maglev'}, {'name': 'mjsunit', 'variant': 'stress_maglev'},
# Experimental regexp engine. # Experimental regexp engine.
@ -943,8 +945,6 @@
}, },
'tests': [ 'tests': [
{'name': 'v8testing'}, {'name': 'v8testing'},
# Maglev -- move to extra once more architectures are supported.
{'name': 'mjsunit', 'variant': 'maglev'},
], ],
}, },
'v8_mac_arm64_dbg': { 'v8_mac_arm64_dbg': {
@ -955,8 +955,6 @@
}, },
'tests': [ 'tests': [
{'name': 'v8testing'}, {'name': 'v8testing'},
# Maglev -- move to extra once more architectures are supported.
{'name': 'mjsunit', 'variant': 'maglev'},
], ],
}, },
'v8_mac_arm64_full_dbg': { 'v8_mac_arm64_full_dbg': {
@ -967,8 +965,6 @@
}, },
'tests': [ 'tests': [
{'name': 'v8testing'}, {'name': 'v8testing'},
# Maglev -- move to extra once more architectures are supported.
{'name': 'mjsunit', 'variant': 'maglev'},
], ],
}, },
'v8_mac_arm64_no_pointer_compression_dbg': { 'v8_mac_arm64_no_pointer_compression_dbg': {
@ -1461,6 +1457,8 @@
{'name': 'webkit', 'variant': 'stress_sampling'}, {'name': 'webkit', 'variant': 'stress_sampling'},
# Stress snapshot. # Stress snapshot.
{'name': 'mjsunit', 'variant': 'stress_snapshot'}, {'name': 'mjsunit', 'variant': 'stress_snapshot'},
# Maglev.
{'name': 'mjsunit', 'variant': 'maglev'},
# Stress maglev. # Stress maglev.
{'name': 'mjsunit', 'variant': 'stress_maglev'}, {'name': 'mjsunit', 'variant': 'stress_maglev'},
# Experimental regexp engine. # Experimental regexp engine.
@ -1523,6 +1521,8 @@
{'name': 'webkit', 'variant': 'stress_sampling'}, {'name': 'webkit', 'variant': 'stress_sampling'},
# Stress snapshot. # Stress snapshot.
{'name': 'mjsunit', 'variant': 'stress_snapshot'}, {'name': 'mjsunit', 'variant': 'stress_snapshot'},
# Maglev.
{'name': 'mjsunit', 'variant': 'maglev'},
# Stress maglev. # Stress maglev.
{'name': 'mjsunit', 'variant': 'stress_maglev'}, {'name': 'mjsunit', 'variant': 'stress_maglev'},
# Experimental regexp engine. # Experimental regexp engine.
@ -1805,8 +1805,6 @@
'tests': [ 'tests': [
{'name': 'v8testing'}, {'name': 'v8testing'},
{'name': 'v8testing', 'variant': 'extra'}, {'name': 'v8testing', 'variant': 'extra'},
# Maglev -- move to extra once more architectures are supported.
{'name': 'mjsunit', 'variant': 'maglev'},
], ],
}, },
'V8 Mac - arm64 - debug': { 'V8 Mac - arm64 - debug': {
@ -1823,8 +1821,6 @@
'tests': [ 'tests': [
{'name': 'v8testing', 'shards': 2}, {'name': 'v8testing', 'shards': 2},
{'name': 'v8testing', 'variant': 'extra', 'shards': 2}, {'name': 'v8testing', 'variant': 'extra', 'shards': 2},
# Maglev -- move to extra once more architectures are supported.
{'name': 'mjsunit', 'variant': 'maglev'},
], ],
}, },
'V8 Mac - arm64 - no pointer compression debug': { 'V8 Mac - arm64 - no pointer compression debug': {