AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbolizer] Remove tslint:recommended so that presubmit can be run

Browse Source 
TSLint has been deprecated and so the presubmit script will not
run because of tslint:recommended. Removing this allows the
explicit rules to be run but does not properly fix the use of
TSLint. Also fix the issues that do not pass the linter.

Bug: v8:7327
Change-Id: I9f463ba9520ee2caa4141b21b81fd15012afedff
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4085145
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: George Wort <george.wort@arm.com>
Cr-Commit-Position: refs/heads/main@{#84725}
This commit is contained in:
George Wort 2022-12-07 19:02:39 +00:00 committed by V8 LUCI CQ
parent c690be58b1
commit d5c6b928ad
3 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/turbolizer/src/phases/schedule-phase.ts
View File

@ -65,7 +65,7 @@ export class SchedulePhase extends Phase {
const blockId = Number.parseInt(match.groups.id, 10);
const block = new ScheduleBlock(blockRpo, blockId, match.groups.deferred !== undefined,
predecessors.sort());
this.data.blocks_rpo[block.rpo] = block;
this.data.blocksRpo[block.rpo] = block;
}
private setGotoSuccessor = match => {
@ -132,15 +132,15 @@ export class ScheduleBlock {
export class ScheduleData {
nodes: Array<ScheduleNode>;
blocks_rpo: Array<ScheduleBlock>;
blocksRpo: Array<ScheduleBlock>;
constructor() {
this.nodes = new Array<ScheduleNode>();
this.blocks_rpo = new Array<ScheduleBlock>();
this.blocksRpo = new Array<ScheduleBlock>();
}
public lastBlock(): ScheduleBlock {
if (this.blocks_rpo.length == 0) return null;
return this.blocks_rpo[this.blocks_rpo.length - 1];
if (this.blocksRpo.length == 0) return null;
return this.blocksRpo[this.blocksRpo.length - 1];
}
}

8
tools/turbolizer/src/views/schedule-view.ts
View File

@ -28,7 +28,7 @@ export class ScheduleView extends TextView {
public initializeContent(schedule: SchedulePhase, rememberedSelection: SelectionStorage): void {
this.divNode.innerHTML = "";
this.schedule = schedule;
this.addBlocks(schedule.data.blocks_rpo);
this.addBlocks(schedule.data.blocksRpo);
this.show();
if (rememberedSelection) {
const adaptedSelection = this.adaptSelection(rememberedSelection);
@ -91,9 +91,9 @@ export class ScheduleView extends TextView {
instrMarker.onclick = this.mkBlockLinkHandler(block.rpo);
scheduleBlock.appendChild(instrMarker);
const blockRpo_Id = this.createElement("div", "block-id com clickable", String(block.rpo) + " Id:" + String(block.id));
blockRpo_Id.onclick = this.mkBlockLinkHandler(block.rpo);
scheduleBlock.appendChild(blockRpo_Id);
const blocksRpoId = this.createElement("div", "block-id com clickable", String(block.rpo) + " Id:" + String(block.id));
blocksRpoId.onclick = this.mkBlockLinkHandler(block.rpo);
scheduleBlock.appendChild(blocksRpoId);
const blockPred = this.createElement("div", "predecessor-list block-list comma-sep-list");
for (const pred of block.predecessors) {
const predEl = this.createElement("div", "block-id com clickable", String(pred));

1
tools/turbolizer/tslint.json
View File

@ -1,6 +1,5 @@
{
"defaultSeverity": "error",
"extends": "tslint:recommended",
"jsRules": {},
"rules": {
"curly": [true, "ignore-same-line"],