AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Generalize representation inference for NumberAdd.

Browse Source 
This should fix the Turbofan Octane/Mandreel regression introduced by

commit 9ea551aa45
Author: jarin <jarin@chromium.org>
Date:   Sun Nov 22 05:45:38 2015 -0800

    [turbofan] Simplify lowering of number addition.

    Review URL: https://codereview.chromium.org/1471533002

    Cr-Commit-Position: refs/heads/master@{#32159}

Review URL: https://codereview.chromium.org/1477803002

Cr-Commit-Position: refs/heads/master@{#32304}
This commit is contained in:
jarin 2015-11-25 12:10:09 -08:00 committed by Commit bot
parent e5b56115a7
commit d5e5e1e161
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/compiler/simplified-lowering.cc
View File

@ -559,9 +559,17 @@ class RepresentationSelector {
NodeProperties::GetType(node)->Is(Type::Signed32())); NodeProperties::GetType(node)->Is(Type::Signed32()));
} }
bool CanLowerToWord32AdditiveBinop(Node* node, Truncation use) { bool CanLowerToInt32AdditiveBinop(Node* node, Truncation use) {
// It is safe to lower to word32 operation if:
// - the inputs are safe integers (so the low bits are not discarded), and
// - the uses can only observe the lowest 32 bits or they can recover the
// the value from the type.
// TODO(jarin): we could support the uint32 case here, but that would
// require setting kTypeUint32 as the output type. Eventually, we will want
// to use only the big types, then this should work automatically.
return BothInputsAre(node, safe_int_additive_range_) && return BothInputsAre(node, safe_int_additive_range_) &&
use.TruncatesToWord32(); (use.TruncatesToWord32() ||
NodeProperties::GetType(node)->Is(Type::Signed32()));
} }
// Dispatching routine for visiting the node {node} with the usage {use}. // Dispatching routine for visiting the node {node} with the usage {use}.
@ -689,7 +697,7 @@ class RepresentationSelector {
case IrOpcode::kNumberSubtract: { case IrOpcode::kNumberSubtract: {
// Add and subtract reduce to Int32Add/Sub if the inputs // Add and subtract reduce to Int32Add/Sub if the inputs
// are already integers and all uses are truncating. // are already integers and all uses are truncating.
if (CanLowerToWord32AdditiveBinop(node, truncation)) { if (CanLowerToInt32AdditiveBinop(node, truncation)) {
// => signed Int32Add/Sub // => signed Int32Add/Sub
VisitInt32Binop(node); VisitInt32Binop(node);
if (lower()) NodeProperties::ChangeOp(node, Int32Op(node)); if (lower()) NodeProperties::ChangeOp(node, Int32Op(node));