AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Don't copy blocks in EnsureCFGWellFormedness

Browse Source 
This is no longer necessary, because `EnsureSplitEdgeForm` no longer
adds new blocks.

Change-Id: I48daaa556ff1be5c9641b054937699ac401613f9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810464
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com>
Cr-Commit-Position: refs/heads/main@{#82305}
This commit is contained in:
Georgia Kouveli 2022-08-08 10:50:00 +01:00 committed by V8 LUCI CQ
parent 25530fd6fb
commit d757c72e09
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/compiler/schedule.cc
View File

@ -332,12 +332,8 @@ void Schedule::InsertSwitch(BasicBlock* block, BasicBlock* end, Node* sw,
} }
void Schedule::EnsureCFGWellFormedness() { void Schedule::EnsureCFGWellFormedness() {
// Make a copy of all the blocks for the iteration, since adding the split // Ensure there are no critical edges.
// edges will allocate new blocks. for (BasicBlock* block : all_blocks_) {
BasicBlockVector all_blocks_copy(all_blocks_);
// Insert missing split edge blocks.
for (BasicBlock* block : all_blocks_copy) {
if (block->PredecessorCount() > 1) { if (block->PredecessorCount() > 1) {
if (block != end_) { if (block != end_) {
EnsureSplitEdgeForm(block); EnsureSplitEdgeForm(block);