AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

PPC/s390: [wasm] Debug in Liftoff by default

Browse Source 
Port 4482650907

Original Commit Message:

    This flips the --debug-in-liftoff flag to be on by default.
    There are still some outstanding issues with that configuration, but not
    more than with the interpreter configuration. Thus flip now, such that
    we can fully focus on stabilizing that config.

R=clemensb@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: Ie18137fe5f1b9533a0882b5e57d8c320ee340387
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142311
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67066}
This commit is contained in:
Milad Farazmand 2020-04-08 15:17:47 +00:00 committed by Commit Bot
parent 24c4b77669
commit d7755bb454
2 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/cctest/cctest.status
View File

@ -393,6 +393,8 @@
# Liftoff is not currently supported on ppc and s390
'test-liftoff-*': [SKIP],
'test-wasm-breakpoints/*' : [SKIP],
'test-wasm-debug-evaluate/*': [SKIP],
# SIMD not fully implemented yet
'test-run-wasm-simd-liftoff/*': [SKIP],

12
test/inspector/inspector.status
View File

@ -75,11 +75,7 @@
##############################################################################
['arch == ppc or arch == ppc64', {
# Liftoff needs to be enabled before running these tests.
'debugger/wasm-scope-info': [SKIP],
'debugger/wasm-scope-info-liftoff': [SKIP],
'debugger/wasm-set-breakpoint-liftoff': [SKIP],
'debugger/wasm-stepping-liftoff': [SKIP],
'debugger/wasm-inspect-many-registers': [SKIP],
'debugger/wasm-*': [SKIP],
}], # 'arch == ppc or arch == ppc64'
##############################################################################
@ -87,11 +83,7 @@
# Stack manipulations in LiveEdit is not implemented for this arch.
'debugger/set-script-source-stack-padding': [SKIP],
# Liftoff needs to be enabled before running these tests.
'debugger/wasm-scope-info': [SKIP],
'debugger/wasm-scope-info-liftoff': [SKIP],
'debugger/wasm-set-breakpoint-liftoff': [SKIP],
'debugger/wasm-stepping-liftoff': [SKIP],
'debugger/wasm-inspect-many-registers': [SKIP],
'debugger/wasm-*': [SKIP],
}], # 'arch == s390 or arch == s390x'
##############################################################################