[cleanup][test] Don't rely on __COUNTER__ in expectations

Browse Source

Several of the cctest/test-bytecode-generator/* tests used to rely
on the __COUNTER__ C++ compiler macro, which could cause spurious
test failures due to mismatched expectations when usages of that
macro were added or removed elsewhere in the code. This patch switches
to a custom, controllable static counter variable instead, to make
the tests' behaviors self-contained.

Bug: v8:12244
Change-Id: I4d875b6095e4ee4ef91933ab8c60c89054d1894a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186836
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77111}

...

This commit is contained in:

Jakob Kummerow 2021-09-27 20:45:12 +02:00 committed by V8 LUCI CQ

parent 89d71aa946

commit d7fc0134ee

1 changed files with 193 additions and 222 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

415

test/cctest/interpreter/test-bytecode-generator.cc

View File

File diff suppressed because it is too large Load Diff