AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Interpreter] Set bytecode array in Runtime_SetCode.

Browse Source 
Set the bytecode array correctly in Runtime_SetCode.
This fixes issues with building the snapshot with ignition enabled.

BUG=v8:4280
LOG=N

Review URL: https://codereview.chromium.org/1647913002

Cr-Commit-Position: refs/heads/master@{#33638}
This commit is contained in:
rmcilroy 2016-02-01 04:12:40 -08:00 committed by Commit bot
parent ca6587c007
commit d81edba721
3 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/runtime/runtime-function.cc
View File

@ -162,6 +162,9 @@ RUNTIME_FUNCTION(Runtime_SetCode) {
// Set the code, scope info, formal parameter count, and the length
// of the target shared function info.
target_shared->ReplaceCode(source_shared->code());
if (source_shared->HasBytecodeArray()) {
target_shared->set_function_data(source_shared->bytecode_array());
}
target_shared->set_scope_info(source_shared->scope_info());
target_shared->set_length(source_shared->length());
target_shared->set_feedback_vector(source_shared->feedback_vector());

13
test/cctest/cctest.status
View File

@ -508,7 +508,6 @@
'test-debug/*' : [SKIP],
'test-func-name-inference/*' : [SKIP],
'test-inobject-slack-tracking/*' : [SKIP],
'test-serialize/*' : [SKIP],
# TODO(mstarzinger,4674): Message object is not properly cleared.
'test-heap/MessageObjectLeak': [FAIL],
@ -519,6 +518,12 @@
# TODO(mstarzinger,4674): Bug in control flow modeling. Investigate and fix.
'test-run-jsexceptions/ThrowMessageIndirectly': [FAIL],
# TODO(rmcilroy,4680): Check failure in runtime-compiler.cc on code type.
'test-serialize/SerializeInternalReference': [FAIL],
# TODO(rmcilroy,4680): Check failed: toplevel_test_code_event_found.
'test-serialize/SerializeToplevelIsolates': [FAIL],
'test-api-interceptors/InterceptorCallICInvalidatedConstantFunctionViaGlobal': [SKIP],
'test-api-interceptors/InterceptorLoadICInvalidatedCallbackViaGlobal': [SKIP],
'test-api-interceptors/InterceptorLoadICInvalidatedFieldViaGlobal': [SKIP],
@ -537,7 +542,6 @@
'test-heap/IncrementalMarkingPreservesMonomorphicCallIC': [SKIP],
'test-heap/IncrementalMarkingPreservesMonomorphicConstructor': [SKIP],
'test-heap/NoWeakHashTableLeakWithIncrementalMarking': [SKIP],
'test-heap-profiler/HeapSnapshotSimd': [SKIP],
'test-heap/OptimizedAllocationAlwaysInNewSpace': [SKIP],
'test-heap/Regress169209': [SKIP],
'test-heap/Regress357137': [SKIP],
@ -584,9 +588,14 @@
'test-unscopables-hidden-prototype/Unscopables': [SKIP],
}], # ignition == True
['ignition == True and arch == arm', {
'test-serialize/SerializeInternalReference': [SKIP],
}],
['ignition == True and arch == arm64', {
'test-decls/CrossScriptReferencesHarmony': [SKIP],
'test-js-arm64-variables/lookup_slots': [SKIP],
'test-serialize/SerializeInternalReference': [SKIP],
'test-spaces/SizeOfFirstPageIsLargeEnough': [SKIP],
'test-heap/AddInstructionChangesNewSpacePromotion': [SKIP],
'test-heap/Regress538257': [SKIP],

1
test/mjsunit/mjsunit.status
View File

@ -797,7 +797,6 @@
'declare-locally': [SKIP],
'delete-in-with': [SKIP],
'deserialize-optimize-inner': [SKIP],
'double-equals': [SKIP],
'eval-enclosing-function-name': [SKIP],
'eval': [SKIP],
'eval-stack-trace': [SKIP],