AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

cctest/test-deoptimization/DeoptimizeCompare was failing on PPC because the path that is optimized for isel incorrectly used integer values instead of Smi's

Browse Source 
BUG=

Review URL: https://codereview.chromium.org/996223002

Cr-Commit-Position: refs/heads/master@{#27136}
This commit is contained in:
michael_dawson 2015-03-11 07:57:57 -07:00 committed by Commit bot
parent 611eb25894
commit d88656af9f
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ppc/code-stubs-ppc.cc
View File

@ -3563,8 +3563,8 @@ void StringHelper::GenerateCompareFlatOneByteStrings(
// Conditionally update the result based either on length_delta or
// the last comparion performed in the loop above.
if (CpuFeatures::IsSupported(ISELECT)) {
__ li(r4, Operand(GREATER));
__ li(r5, Operand(LESS));
__ LoadSmiLiteral(r4, Smi::FromInt(GREATER));
__ LoadSmiLiteral(r5, Smi::FromInt(LESS));
__ isel(eq, r3, r0, r4);
__ isel(lt, r3, r5, r3);
__ Ret();

1
test/cctest/cctest.status
View File

@ -407,7 +407,6 @@
# issues to be investigated based on latest uplevel
'test-run-machops/RunWord64EqualInBranchP': [SKIP],
'test-deoptimization/DeoptimizeCompare': [SKIP],
# will not pass until we agree/implement changes to serializce.cc
'test-serialize/SerializeInternalReference': [SKIP],