From d88f4d33c267a995c4b9a66c0b778faff5ae4bdb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Z=C3=BCnd?= Date: Wed, 3 Apr 2019 08:46:58 -0700 Subject: [PATCH] [cleanup] Remove unused field 'id' from StackFrameInfo class MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As part of one of the stack trace refactorings, this field moved from StackFrameInfo to the StackTraceFrame class, but was not properly removed. R=petermarshall@chromium.org Bug: v8:8742 Change-Id: I18b9bd7650eed0f5bdb0823da9fdefb6afa3491e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550800 Reviewed-by: Peter Marshall Commit-Queue: Simon Zünd Cr-Commit-Position: refs/heads/master@{#60659} --- src/builtins/base.tq | 1 - src/objects/stack-frame-info-inl.h | 1 - src/objects/stack-frame-info.h | 1 - 3 files changed, 3 deletions(-) diff --git a/src/builtins/base.tq b/src/builtins/base.tq index 1ef876a173..ff7b8e55da 100644 --- a/src/builtins/base.tq +++ b/src/builtins/base.tq @@ -634,7 +634,6 @@ extern class StackFrameInfo extends Struct { script_name_or_source_url: Object; function_name: Object; flag: Smi; - id: Smi; } extern class ClassPositions extends Struct { diff --git a/src/objects/stack-frame-info-inl.h b/src/objects/stack-frame-info-inl.h index 4bcf3a5672..1007c78b18 100644 --- a/src/objects/stack-frame-info-inl.h +++ b/src/objects/stack-frame-info-inl.h @@ -35,7 +35,6 @@ SMI_ACCESSORS(StackFrameInfo, flag, kFlagOffset) BOOL_ACCESSORS(StackFrameInfo, flag, is_eval, kIsEvalBit) BOOL_ACCESSORS(StackFrameInfo, flag, is_constructor, kIsConstructorBit) BOOL_ACCESSORS(StackFrameInfo, flag, is_wasm, kIsWasmBit) -SMI_ACCESSORS(StackFrameInfo, id, kIdOffset) OBJECT_CONSTRUCTORS_IMPL(StackTraceFrame, Struct) NEVER_READ_ONLY_SPACE_IMPL(StackTraceFrame) diff --git a/src/objects/stack-frame-info.h b/src/objects/stack-frame-info.h index cb67637119..2621f8f8ed 100644 --- a/src/objects/stack-frame-info.h +++ b/src/objects/stack-frame-info.h @@ -28,7 +28,6 @@ class StackFrameInfo : public Struct { DECL_BOOLEAN_ACCESSORS(is_constructor) DECL_BOOLEAN_ACCESSORS(is_wasm) DECL_INT_ACCESSORS(flag) - DECL_INT_ACCESSORS(id) DECL_CAST(StackFrameInfo)