From d8a965a07c2bf869fa75eb8f5292748a0bfa73df Mon Sep 17 00:00:00 2001 From: Yang Guo Date: Tue, 16 Jan 2018 11:02:14 +0100 Subject: [PATCH] [tools] tools/node/fetch_deps.py returns False. This will act as a switch so that we can enable Node.js GN builds via V8 change. R=machenbach@chromium.org Bug: v8:6105 Change-Id: Ie786a4dad7f53e4bbf7d8830bb72b1f8031cee12 Reviewed-on: https://chromium-review.googlesource.com/866839 Reviewed-by: Michael Achenbach Commit-Queue: Yang Guo Cr-Commit-Position: refs/heads/master@{#50612} --- tools/node/fetch_deps.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/node/fetch_deps.py b/tools/node/fetch_deps.py index e14f3a0f1b..0d7cdd1ddd 100755 --- a/tools/node/fetch_deps.py +++ b/tools/node/fetch_deps.py @@ -89,5 +89,11 @@ def FetchDeps(v8_path): if os.path.isfile(gclient_entries): os.remove(gclient_entries) + # TODO(v8:6105): + # The return value gates whether Node's configure script actually + # uses GN. Change this to true once everything is ready so that + # the change to enable the GN build on the bots comes from V8. + return False; + if __name__ == "__main__": FetchDeps(sys.argv[1])