AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[inspector] Remove unused V8StackTrace::buildInspectorObject().

Browse Source 
This is an unused overload, which doesn't add any value to keep around.

Bug: none
Change-Id: I6e004e28f6ec8d4c8de87a1e86d331a624694659
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297896
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78052}
This commit is contained in:
Benedikt Meurer 2021-11-23 16:37:11 +01:00 committed by V8 LUCI CQ
parent b1a6f76983
commit d915b90254
3 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/v8-inspector.h
View File

@ -118,8 +118,6 @@ class V8_EXPORT V8StackTrace {
virtual ~V8StackTrace() = default;
virtual std::unique_ptr<protocol::Runtime::API::StackTrace>
buildInspectorObject() const = 0;
virtual std::unique_ptr<protocol::Runtime::API::StackTrace>
buildInspectorObject(int maxAsyncDepth) const = 0;
virtual std::unique_ptr<StringBuffer> toString() const = 0;

5
src/inspector/v8-stack-trace-impl.cc
View File

@ -330,11 +330,6 @@ V8StackTraceImpl::buildInspectorObjectImpl(V8Debugger* debugger,
maxAsyncDepth);
}
std::unique_ptr<protocol::Runtime::API::StackTrace>
V8StackTraceImpl::buildInspectorObject() const {
return buildInspectorObjectImpl(nullptr);
}
std::unique_ptr<protocol::Runtime::API::StackTrace>
V8StackTraceImpl::buildInspectorObject(int maxAsyncDepth) const {
return buildInspectorObjectImpl(nullptr,

2
src/inspector/v8-stack-trace-impl.h
View File

@ -79,8 +79,6 @@ class V8StackTraceImpl : public V8StackTrace {
int topColumnNumber() const override; // 1-based.
int topScriptId() const override;
StringView topFunctionName() const override;
std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject()
const override;
std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject(
int maxAsyncDepth) const override;
std::unique_ptr<StringBuffer> toString() const override;