AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove redundant logic in AllowedToBeMigrated

Browse Source 
Simplifies boolean logic since shortcuts mean most will never be
executed and also replaces variables with constants to improve
readability.

Change-Id: Ic1678bc60c3e85daced758ce139f7d03c25632dc
Reviewed-on: https://chromium-review.googlesource.com/928320
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51419}
This commit is contained in:
Dan Elphick 2018-02-21 09:37:37 +00:00 committed by Commit Bot
parent 3537bc6e81
commit d9e305d47c
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/heap/heap.cc
View File

@ -6644,12 +6644,11 @@ bool Heap::AllowedToBeMigrated(HeapObject* obj, AllocationSpace dst) {
AllocationSpace src = chunk->owner()->identity(); AllocationSpace src = chunk->owner()->identity();
switch (src) { switch (src) {
case NEW_SPACE: case NEW_SPACE:
return dst == src || dst == OLD_SPACE; return dst == NEW_SPACE || dst == OLD_SPACE;
case OLD_SPACE: case OLD_SPACE:
return dst == src && return dst == OLD_SPACE;
(dst == OLD_SPACE || obj->IsFiller() || obj->IsExternalString());
case CODE_SPACE: case CODE_SPACE:
return dst == src && type == CODE_TYPE; return dst == CODE_SPACE && type == CODE_TYPE;
case MAP_SPACE: case MAP_SPACE:
case LO_SPACE: case LO_SPACE:
return false; return false;