AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[Inspector] Adjust the length of some of the console functions."

Browse Source 
This reverts commit 2974a184fd.

Reason for revert: For this change to land, layout tests have to 
be changed on the chromium side:
https://ci.chromium.org/p/v8/builders/ci/V8-Blink%20Linux%2064/31448
https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64/31448/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html

Original change's description:
> [Inspector] Adjust the length of some of the console functions.
> 
> The function lengths on a number of the console methods was set to 1.
> The arguments to these functions are either variadic or optional so they
> should have length of 0.
> 
> R=​dgozman@chromium.org,ulan@chromium.org
> BUG=chromium:948678
> 
> Change-Id: I183262e230145a565732396688a0541034931500
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1548948
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Pavel Feldman OOO <pfeldman@chromium.org>
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#61021}

TBR=dgozman@chromium.org,ulan@chromium.org,pfeldman@chromium.org,yangguo@chromium.org,dtapuska@chromium.org,kozyatinskiy@chromium.org

Change-Id: Iba25e9351641c5d2730eb727f3da91f86d5b1203
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:948678
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585719
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61029}
This commit is contained in:
Sigurd Schneider 2019-04-26 06:36:29 +00:00 committed by Commit Bot
parent 7bbb9b8bfe
commit da41977d09
1 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/bootstrapper.cc
View File

@ -2799,49 +2799,49 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
DCHECK(console->IsJSObject());
JSObject::AddProperty(isolate_, global, name, console, DONT_ENUM);
SimpleInstallFunction(isolate_, console, "debug", Builtins::kConsoleDebug,
0, false, NONE);
1, false, NONE);
SimpleInstallFunction(isolate_, console, "error", Builtins::kConsoleError,
0, false, NONE);
SimpleInstallFunction(isolate_, console, "info", Builtins::kConsoleInfo, 0,
1, false, NONE);
SimpleInstallFunction(isolate_, console, "info", Builtins::kConsoleInfo, 1,
false, NONE);
SimpleInstallFunction(isolate_, console, "log", Builtins::kConsoleLog, 0,
SimpleInstallFunction(isolate_, console, "log", Builtins::kConsoleLog, 1,
false, NONE);
SimpleInstallFunction(isolate_, console, "warn", Builtins::kConsoleWarn, 0,
SimpleInstallFunction(isolate_, console, "warn", Builtins::kConsoleWarn, 1,
false, NONE);
SimpleInstallFunction(isolate_, console, "dir", Builtins::kConsoleDir, 1,
false, NONE);
SimpleInstallFunction(isolate_, console, "dirxml", Builtins::kConsoleDirXml,
0, false, NONE);
1, false, NONE);
SimpleInstallFunction(isolate_, console, "table", Builtins::kConsoleTable,
1, false, NONE);
SimpleInstallFunction(isolate_, console, "trace", Builtins::kConsoleTrace,
0, false, NONE);
1, false, NONE);
SimpleInstallFunction(isolate_, console, "group", Builtins::kConsoleGroup,
0, false, NONE);
1, false, NONE);
SimpleInstallFunction(isolate_, console, "groupCollapsed",
Builtins::kConsoleGroupCollapsed, 0, false, NONE);
Builtins::kConsoleGroupCollapsed, 1, false, NONE);
SimpleInstallFunction(isolate_, console, "groupEnd",
Builtins::kConsoleGroupEnd, 0, false, NONE);
Builtins::kConsoleGroupEnd, 1, false, NONE);
SimpleInstallFunction(isolate_, console, "clear", Builtins::kConsoleClear,
0, false, NONE);
1, false, NONE);
SimpleInstallFunction(isolate_, console, "count", Builtins::kConsoleCount,
0, false, NONE);
1, false, NONE);
SimpleInstallFunction(isolate_, console, "countReset",
Builtins::kConsoleCountReset, 0, false, NONE);
Builtins::kConsoleCountReset, 1, false, NONE);
SimpleInstallFunction(isolate_, console, "assert",
Builtins::kFastConsoleAssert, 0, false, NONE);
Builtins::kFastConsoleAssert, 1, false, NONE);
SimpleInstallFunction(isolate_, console, "profile",
Builtins::kConsoleProfile, 0, false, NONE);
Builtins::kConsoleProfile, 1, false, NONE);
SimpleInstallFunction(isolate_, console, "profileEnd",
Builtins::kConsoleProfileEnd, 0, false, NONE);
SimpleInstallFunction(isolate_, console, "time", Builtins::kConsoleTime, 0,
Builtins::kConsoleProfileEnd, 1, false, NONE);
SimpleInstallFunction(isolate_, console, "time", Builtins::kConsoleTime, 1,
false, NONE);
SimpleInstallFunction(isolate_, console, "timeLog",
Builtins::kConsoleTimeLog, 0, false, NONE);
Builtins::kConsoleTimeLog, 1, false, NONE);
SimpleInstallFunction(isolate_, console, "timeEnd",
Builtins::kConsoleTimeEnd, 0, false, NONE);
Builtins::kConsoleTimeEnd, 1, false, NONE);
SimpleInstallFunction(isolate_, console, "timeStamp",
Builtins::kConsoleTimeStamp, 0, false, NONE);
Builtins::kConsoleTimeStamp, 1, false, NONE);
SimpleInstallFunction(isolate_, console, "context",
Builtins::kConsoleContext, 1, true, NONE);
InstallToStringTag(isolate_, console, "Object");