AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Remove ArgumentsAdaptorFrameInfo

Browse Source 
Change-Id: Ia05a7bfcb56984658d4448c7d52150dfbadd0660
Bug: v8:11312
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2639953
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72188}
This commit is contained in:
Victor Gomes 2021-01-20 09:44:41 +01:00 committed by Commit Bot
parent ecaac3292f
commit da9d340a9a
3 changed files with 5 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/compiler/backend/instruction.cc
View File

@ -1008,11 +1008,11 @@ size_t GetConservativeFrameSizeInBytes(FrameStateType type,
static_cast<int>(parameters_count), static_cast<int>(locals_count)); static_cast<int>(parameters_count), static_cast<int>(locals_count));
return info.frame_size_in_bytes(); return info.frame_size_in_bytes();
} }
case FrameStateType::kArgumentsAdaptor: { case FrameStateType::kArgumentsAdaptor:
auto info = ArgumentsAdaptorFrameInfo::Conservative( // The arguments adaptor frame state is only used in the deoptimizer and
static_cast<int>(parameters_count)); // does not occupy any extra space in the stack. Check out the design doc:
return info.frame_size_in_bytes(); // https://docs.google.com/document/d/150wGaUREaZI6YWqOQFD5l2mWQXaPbbZjcAIJLOFrzMs/edit
} return 0;
case FrameStateType::kConstructStub: { case FrameStateType::kConstructStub: {
auto info = ConstructStubFrameInfo::Conservative( auto info = ConstructStubFrameInfo::Conservative(
static_cast<int>(parameters_count)); static_cast<int>(parameters_count));

10
src/execution/frames.cc
View File

@ -2225,16 +2225,6 @@ InterpretedFrameInfo::InterpretedFrameInfo(int parameters_count_with_receiver,
frame_size_in_bytes_ = frame_size_in_bytes_without_fixed_ + fixed_frame_size; frame_size_in_bytes_ = frame_size_in_bytes_without_fixed_ + fixed_frame_size;
} }
ArgumentsAdaptorFrameInfo::ArgumentsAdaptorFrameInfo(int translation_height) {
// Note: This is according to the Translation's notion of 'parameters' which
// differs to that of the SharedFunctionInfo, e.g. by including the receiver.
const int parameters_count = translation_height;
frame_size_in_bytes_without_fixed_ =
(parameters_count + ArgumentPaddingSlots(parameters_count)) *
kSystemPointerSize;
frame_size_in_bytes_ = frame_size_in_bytes_without_fixed_;
}
ConstructStubFrameInfo::ConstructStubFrameInfo(int translation_height, ConstructStubFrameInfo::ConstructStubFrameInfo(int translation_height,
bool is_topmost, bool is_topmost,
FrameInfoKind frame_info_kind) { FrameInfoKind frame_info_kind) {

24
src/execution/frames.h
View File

@ -1318,30 +1318,6 @@ class InterpretedFrameInfo {
uint32_t frame_size_in_bytes_; uint32_t frame_size_in_bytes_;
}; };
// TODO(v8:11312): Now that we don't have arguments adaptor frames anymore, we
// might be able to remove this class.
class ArgumentsAdaptorFrameInfo {
public:
static ArgumentsAdaptorFrameInfo Precise(int translation_height) {
return ArgumentsAdaptorFrameInfo{translation_height};
}
static ArgumentsAdaptorFrameInfo Conservative(int parameters_count) {
return ArgumentsAdaptorFrameInfo{parameters_count};
}
uint32_t frame_size_in_bytes_without_fixed() const {
return frame_size_in_bytes_without_fixed_;
}
uint32_t frame_size_in_bytes() const { return frame_size_in_bytes_; }
private:
explicit ArgumentsAdaptorFrameInfo(int translation_height);
uint32_t frame_size_in_bytes_without_fixed_;
uint32_t frame_size_in_bytes_;
};
class ConstructStubFrameInfo { class ConstructStubFrameInfo {
public: public:
static ConstructStubFrameInfo Precise(int translation_height, static ConstructStubFrameInfo Precise(int translation_height,