AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[mips][wasm] Fix non-const references in Liftoff.

Browse Source 
Fix build error which is introduced by 9f8d52d
https://crrev.com/c/1701844

Change-Id: I31266daf46ddc67390379f935568e3443593a262
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1703988
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Yu Yin <xwafish@gmail.com>
Cr-Commit-Position: refs/heads/master@{#62756}
This commit is contained in:
Yu Yin 2019-07-17 11:09:41 +08:00 committed by Commit Bot
parent a99512c700
commit db2c7dd43f
2 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/wasm/baseline/mips/liftoff-assembler-mips.h
View File

@ -1239,25 +1239,25 @@ inline FPUCondition ConditionToConditionCmpFPU(Condition condition,
bool* predicate) { bool* predicate) {
switch (condition) { switch (condition) {
case kEqual: case kEqual:
predicate = true; *predicate = true;
return EQ; return EQ;
case kUnequal: case kUnequal:
predicate = false; *predicate = false;
return EQ; return EQ;
case kUnsignedLessThan: case kUnsignedLessThan:
predicate = true; *predicate = true;
return OLT; return OLT;
case kUnsignedGreaterEqual: case kUnsignedGreaterEqual:
predicate = false; *predicate = false;
return OLT; return OLT;
case kUnsignedLessEqual: case kUnsignedLessEqual:
predicate = true; *predicate = true;
return OLE; return OLE;
case kUnsignedGreaterThan: case kUnsignedGreaterThan:
predicate = false; *predicate = false;
return OLE; return OLE;
default: default:
predicate = true; *predicate = true;
break; break;
} }
UNREACHABLE(); UNREACHABLE();
@ -1312,7 +1312,7 @@ void LiftoffAssembler::emit_f64_set_cond(Condition cond, Register dst,
TurboAssembler::li(dst, 1); TurboAssembler::li(dst, 1);
bool predicate; bool predicate;
FPUCondition fcond = liftoff::ConditionToConditionCmpFPU(cond, predicate); FPUCondition fcond = liftoff::ConditionToConditionCmpFPU(cond, &predicate);
TurboAssembler::CompareF64(fcond, lhs, rhs); TurboAssembler::CompareF64(fcond, lhs, rhs);
if (predicate) { if (predicate) {
TurboAssembler::LoadZeroIfNotFPUCondition(dst); TurboAssembler::LoadZeroIfNotFPUCondition(dst);

14
src/wasm/baseline/mips64/liftoff-assembler-mips64.h
View File

@ -1098,25 +1098,25 @@ inline FPUCondition ConditionToConditionCmpFPU(Condition condition,
bool* predicate) { bool* predicate) {
switch (condition) { switch (condition) {
case kEqual: case kEqual:
predicate = true; *predicate = true;
return EQ; return EQ;
case kUnequal: case kUnequal:
predicate = false; *predicate = false;
return EQ; return EQ;
case kUnsignedLessThan: case kUnsignedLessThan:
predicate = true; *predicate = true;
return OLT; return OLT;
case kUnsignedGreaterEqual: case kUnsignedGreaterEqual:
predicate = false; *predicate = false;
return OLT; return OLT;
case kUnsignedLessEqual: case kUnsignedLessEqual:
predicate = true; *predicate = true;
return OLE; return OLE;
case kUnsignedGreaterThan: case kUnsignedGreaterThan:
predicate = false; *predicate = false;
return OLE; return OLE;
default: default:
predicate = true; *predicate = true;
break; break;
} }
UNREACHABLE(); UNREACHABLE();