AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Remove dead code

Browse Source 
Background task restarting happens now in the CompilationState and not
in the AsyncCompileJob. The code in the AsyncCompileJob is dead, so I
remove it.

R=titzer@chromium.org

Change-Id: Ife52522a00ec43aa0f9ad50f8e0114c1e4da5db7
Reviewed-on: https://chromium-review.googlesource.com/978322
Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52190}
This commit is contained in:
Andreas Haas 2018-03-23 16:00:21 +01:00 committed by Commit Bot
parent 650cc48159
commit dba6f74b2d
2 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/wasm/module-compiler.cc
View File

@ -2918,15 +2918,6 @@ void AsyncCompileJob::StartBackgroundTask() {
base::make_unique<CompileTask>(this, false));
}
void AsyncCompileJob::RestartBackgroundTasks() {
int num_restarts = stopped_tasks_.Value();
stopped_tasks_.Decrement(num_restarts);
for (int i = 0; i < num_restarts; ++i) {
StartBackgroundTask();
}
}
template <typename Step, typename... Args>
void AsyncCompileJob::DoAsync(Args&&... args) {
NextStep<Step>(std::forward<Args>(args)...);

4
src/wasm/module-compiler.h
View File

@ -151,8 +151,6 @@ class AsyncCompileJob {
void StartBackgroundTask();
void RestartBackgroundTasks();
// Switches to the compilation step {Step} and starts a foreground task to
// execute it.
template <typename Step, typename... Args>
@ -191,8 +189,6 @@ class AsyncCompileJob {
std::shared_ptr<v8::TaskRunner> foreground_task_runner_;
std::shared_ptr<v8::TaskRunner> background_task_runner_;
// The number of background tasks which stopped executing within a step.
base::AtomicNumber<int32_t> stopped_tasks_{0};
// For async compilation the AsyncCompileJob is the only finisher. For
// streaming compilation also the AsyncStreamingProcessor has to finish before