AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] fix wasm atomic wait callback test on BE

Browse Source 
Bug: v8:8075
Change-Id: I8547706b56bab28dc11685e73b5fc084c8f1bf69
Reviewed-on: https://chromium-review.googlesource.com/c/1480912
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59799}
This commit is contained in:
Junliang Yan 2019-02-22 10:21:49 -05:00 committed by Commit Bot
parent 03e13f7a47
commit dc13819ff4
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/cctest/test-api.cc
View File

@ -27668,7 +27668,7 @@ void AtomicsWaitCallbackCommon(v8::Isolate* isolate, Local<Value> sab,
info.action = AtomicsWaitCallbackAction::StopAndThrowInSecondCall;
info.ncalls = 0;
CompileRun(
"int32arr[1] = 200;"
"setArrayElemAs(1, 200);"
"wait(1, 200);");
CHECK_EQ(info.ncalls, 2);
CHECK(try_catch.HasCaught());
@ -27686,7 +27686,7 @@ void AtomicsWaitCallbackCommon(v8::Isolate* isolate, Local<Value> sab,
info.action = AtomicsWaitCallbackAction::StopFromThreadAndThrow;
info.ncalls = 0;
CompileRun(
"int32arr[1] = 0;"
"setArrayElemAs(1, 0);"
"wait(0, 0);");
CHECK_EQ(info.ncalls, 2);
CHECK(try_catch.HasCaught());
@ -27702,6 +27702,9 @@ TEST(AtomicsWaitCallback) {
const char* init = R"(
let sab = new SharedArrayBuffer(16);
let int32arr = new Int32Array(sab, 4);
let setArrayElemAs = function(id, val) {
int32arr[id] = val;
};
let wait = function(id, val, timeout) {
if(arguments.length == 2) return Atomics.wait(int32arr, id, val);
return Atomics.wait(int32arr, id, val, timeout);
@ -27738,6 +27741,9 @@ TEST(WasmI32AtomicWaitCallback) {
const char* init = R"(
let int32arr = new Int32Array(sab, 4);
let setArrayElemAs = function(id, val) {
int32arr[id] = val;
};
let wait = function(id, val, timeout) {
if(arguments.length === 2)
return func(id << 2, val, -1);
@ -27771,9 +27777,10 @@ TEST(WasmI64AtomicWaitCallback) {
.FromJust());
const char* init = R"(
// offset 12 below ensures that int32arr[1] and wait(1..) point to the
// same address.
let int32arr = new Int32Array(sab, 12);
let int64arr = new BigInt64Array(sab, 8);
let setArrayElemAs = function(id, val) {
int64arr[id] = BigInt(val);
};
let wait = function(id, val, timeout) {
if(arguments.length === 2)
return func(id << 3, val, -1);