AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix typo in r19923 (bounds check offset propagation)

Browse Source 
BUG=chromium:352929
LOG=n
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/201303002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19969 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
jkummerow@chromium.org 2014-03-17 09:38:01 +00:00
parent 8280481cc9
commit dc458525ad
2 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hydrogen-bce.cc
View File

@ -183,7 +183,7 @@ class BoundsCheckBbData: public ZoneObject {
lower_check_ = new_check;
} else {
TightenCheck(lower_check_, new_check);
UpdateLowerOffsets(upper_check_, upper_offset_);
UpdateLowerOffsets(lower_check_, lower_offset_);
}
} else {
// Should never have called CoverCheck() in this case.

33
test/mjsunit/regress/regress-crbug-352929.js Normal file
View File

@ -0,0 +1,33 @@
// Copyright 2014 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax
var dummy = new Int32Array(100);
array = new Int32Array(100);
var dummy2 = new Int32Array(100);
array[-17] = 0;
function fun(base,cond) {
array[base - 1] = 1;
array[base - 2] = 2;
if (cond) {
array[base - 4] = 3;
array[base - 5] = 4;
} else {
array[base - 6] = 5;
array[base - 100] = 777;
}
}
fun(5,true);
fun(7,false);
%OptimizeFunctionOnNextCall(fun);
fun(7,false);
for (var i = 0; i < dummy.length; i++) {
assertEquals(0, dummy[i]);
}
for (var i = 0; i < dummy2.length; i++) {
assertEquals(0, dummy2[i]);
}