AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Don't generate preparse data if lazy-flag is false.

Browse Source 
Review URL: http://codereview.chromium.org/3304012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5427 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
lrn@chromium.org 2010-09-08 10:33:15 +00:00
parent d6b50d5a12
commit dc4898aae2
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/compiler.cc
View File

@ -269,9 +269,20 @@ Handle<SharedFunctionInfo> Compiler::Compile(Handle<String> source,
} }
if (result.is_null()) { if (result.is_null()) {
// No cache entry found. Do pre-parsing and compile the script. // No cache entry found. Do pre-parsing, if it makes sense, and compile
// the script.
// Building preparse data that is only used immediately after is only a
// saving if we might skip building the AST for lazily compiled functions.
// I.e., preparse data isn't relevant when the lazy flag is off, and
// for small sources, odds are that there aren't many functions
// that would be compiled lazily anyway, so we skip the preparse step
// in that case too.
// TODO(lrn): Maybe *only* collect function info, not symbol info, in
// this case, since it's just replacing one hash-lookup with another.
ScriptDataImpl* pre_data = input_pre_data; ScriptDataImpl* pre_data = input_pre_data;
if (pre_data == NULL && source_length >= FLAG_min_preparse_length) { if (pre_data == NULL
&& FLAG_lazy
&& source_length >= FLAG_min_preparse_length) {
pre_data = PreParse(source, NULL, extension); pre_data = PreParse(source, NULL, extension);
} }