AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Mark dead JSInliner::Reduce as UNREACHABLE

Browse Source 
This function is not used (anymore) but needs to be defined, so put an
UNREACHBLE inside.

Bug: v8:7790
Change-Id: I5a8df2cbc236f60ee95ccc9d91c288d8d9c19060
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1515792
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60188}
This commit is contained in:
Georg Neis 2019-03-11 18:00:09 +01:00 committed by Commit Bot
parent 4bf5e119c9
commit dc800881c3
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/compiler/js-inlining.cc
View File

@ -370,11 +370,6 @@ void JSInliner::DetermineCallContext(
UNREACHABLE();
}
Reduction JSInliner::Reduce(Node* node) {
if (!IrOpcode::IsInlineeOpcode(node->opcode())) return NoChange();
return ReduceJSCall(node);
}
Handle<Context> JSInliner::native_context() const {
return handle(info_->native_context(), isolate());
}

3
src/compiler/js-inlining.h
View File

@ -35,8 +35,7 @@ class JSInliner final : public AdvancedReducer {
const char* reducer_name() const override { return "JSInliner"; }
// Reducer interface, eagerly inlines everything.
Reduction Reduce(Node* node) final;
Reduction Reduce(Node* node) final { UNREACHABLE(); }
// Can be used by inlining heuristics or by testing code directly, without
// using the above generic reducer interface of the inlining machinery.