Some cosmetic issues.
Review URL: http://codereview.chromium.org/903004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
parent
c9b9c431d4
commit
dca7574e6e
@ -1107,7 +1107,7 @@ function SetupArray() {
|
|||||||
if (specialFunctions.hasOwnProperty(name)) {
|
if (specialFunctions.hasOwnProperty(name)) {
|
||||||
f = specialFunctions[name];
|
f = specialFunctions[name];
|
||||||
}
|
}
|
||||||
if (arguments.length == 3) {
|
if (!IS_UNDEFINED(len)) {
|
||||||
%FunctionSetLength(f, len);
|
%FunctionSetLength(f, len);
|
||||||
}
|
}
|
||||||
return f;
|
return f;
|
||||||
|
@ -1247,7 +1247,7 @@ Object* CallStubCompiler::CompileArrayPushCall(Object* object,
|
|||||||
|
|
||||||
// Check that the elements are in fast mode (not dictionary).
|
// Check that the elements are in fast mode (not dictionary).
|
||||||
__ cmp(FieldOperand(ebx, HeapObject::kMapOffset),
|
__ cmp(FieldOperand(ebx, HeapObject::kMapOffset),
|
||||||
Immediate(Factory::fixed_array_map()));
|
Immediate(Factory::fixed_array_map()));
|
||||||
__ j(not_equal, &miss);
|
__ j(not_equal, &miss);
|
||||||
|
|
||||||
if (argc == 1) { // Otherwise fall through to call builtin.
|
if (argc == 1) { // Otherwise fall through to call builtin.
|
||||||
@ -1277,7 +1277,7 @@ Object* CallStubCompiler::CompileArrayPushCall(Object* object,
|
|||||||
__ mov(ecx, Operand(esp, argc * kPointerSize));
|
__ mov(ecx, Operand(esp, argc * kPointerSize));
|
||||||
__ mov(Operand(edx, 0), ecx);
|
__ mov(Operand(edx, 0), ecx);
|
||||||
|
|
||||||
// Check if wrote not a smi.
|
// Check if value is a smi.
|
||||||
__ test(ecx, Immediate(kSmiTagMask));
|
__ test(ecx, Immediate(kSmiTagMask));
|
||||||
__ j(not_zero, &with_rset_update);
|
__ j(not_zero, &with_rset_update);
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user