AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset

Browse Source 
BUG=

Review URL: https://codereview.chromium.org/1019563002

Cr-Commit-Position: refs/heads/master@{#27280}
This commit is contained in:
verwaest 2015-03-18 12:53:37 -07:00 committed by Commit bot
parent 68abc2263f
commit dda2bd6f4f
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ic/arm/handler-compiler-arm.cc
View File

@ -728,7 +728,7 @@ Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
Register result = StoreDescriptor::ValueRegister();
Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell);
__ LoadWeakValue(result, weak_cell, &miss);
__ ldr(result, FieldMemOperand(result, Cell::kValueOffset));
__ ldr(result, FieldMemOperand(result, PropertyCell::kValueOffset));
// Check for deleted property if property can actually be deleted.
if (is_configurable) {

2
src/ic/arm64/handler-compiler-arm64.cc
View File

@ -345,7 +345,7 @@ Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
Register result = StoreDescriptor::ValueRegister();
Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell);
__ LoadWeakValue(result, weak_cell, &miss);
__ Ldr(result, FieldMemOperand(result, Cell::kValueOffset));
__ Ldr(result, FieldMemOperand(result, PropertyCell::kValueOffset));
// Check for deleted property if property can actually be deleted.
if (is_configurable) {

3
src/ic/x64/handler-compiler-x64.cc
View File

@ -209,7 +209,8 @@ void PropertyHandlerCompiler::GenerateCheckPropertyCell(
Factory* factory = masm->isolate()->factory();
Handle<WeakCell> weak_cell = factory->NewWeakCell(cell);
__ LoadWeakValue(scratch, weak_cell, miss);
__ Cmp(FieldOperand(scratch, Cell::kValueOffset), factory->the_hole_value());
__ Cmp(FieldOperand(scratch, PropertyCell::kValueOffset),
factory->the_hole_value());
__ j(not_equal, miss);
}