AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cpu-profiler] Fix incorrect line number calculation.

Browse Source 
Previously when we put offsets into the SourcePositionTable, we added
the header size of the code object as well. When we pull the positions
out of the table (see ProfileGenerator::RecordTickSample) we already
account for the header size. This means the offsets in the table should
just be the offset of the PC within the actual code, not the offset
within the code object, which is what we currently store.

Currently this bug is probably not very noticeable, as it causes the
reported line numbers to be slightly too low, but still within the same
function. For a sampling profiler, we don't have any way to confirm
which lines were actually sampled, so we don't notice that the results
are wrong. The only way to see this bug is that there are some lines
within a function (towards the end of the function) that we will never
see ticks inside of, because the offset in the position table is not
reachable with valid PC offsets.

This CL removes the header size offset from values put into the source
position table stored by the profiler.

Bug: v8:7018
Change-Id: I00b17cec5f9c81d993d4e64c3c021052745a791e
Reviewed-on: https://chromium-review.googlesource.com/1016560
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52671}
This commit is contained in:
Peter Marshall 2018-04-18 11:36:59 +02:00 committed by Commit Bot
parent 53d63e7104
commit ddb2856f39
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/profiler/profiler-listener.cc
View File

@ -87,8 +87,6 @@ void ProfilerListener::CodeCreateEvent(CodeEventListener::LogEventsAndTags tag,
if (shared->script()->IsScript()) {
Script* script = Script::cast(shared->script());
line_table.reset(new SourcePositionTable());
int offset = abstract_code->IsCode() ? Code::kHeaderSize
: BytecodeArray::kHeaderSize;
for (SourcePositionTableIterator it(abstract_code->source_position_table());
!it.done(); it.Advance()) {
// TODO(alph,tebbi) Skipping inlined positions for now, because they might
@ -97,8 +95,7 @@ void ProfilerListener::CodeCreateEvent(CodeEventListener::LogEventsAndTags tag,
continue;
int position = it.source_position().ScriptOffset();
int line_number = script->GetLineNumber(position) + 1;
int pc_offset = it.code_offset() + offset;
line_table->SetPosition(pc_offset, line_number);
line_table->SetPosition(it.code_offset(), line_number);
}
}
rec->entry = NewCodeEntry(