Cleanup: Rename Simulator::watched_stops to match style guide.
BUG=none Review URL: https://chromiumcodereview.appspot.com/13469002 Patch from Hans Wennborg <hans@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
parent
fed279a553
commit
de17fa5b4c
@ -112,8 +112,8 @@ void ArmDebugger::Stop(Instruction* instr) {
|
|||||||
ASSERT(msg != NULL);
|
ASSERT(msg != NULL);
|
||||||
|
|
||||||
// Update this stop description.
|
// Update this stop description.
|
||||||
if (isWatchedStop(code) && !watched_stops[code].desc) {
|
if (isWatchedStop(code) && !watched_stops_[code].desc) {
|
||||||
watched_stops[code].desc = msg;
|
watched_stops_[code].desc = msg;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (strlen(msg) > 0) {
|
if (strlen(msg) > 0) {
|
||||||
@ -141,8 +141,8 @@ void ArmDebugger::Stop(Instruction* instr) {
|
|||||||
char* msg = *reinterpret_cast<char**>(sim_->get_pc()
|
char* msg = *reinterpret_cast<char**>(sim_->get_pc()
|
||||||
+ Instruction::kInstrSize);
|
+ Instruction::kInstrSize);
|
||||||
// Update this stop description.
|
// Update this stop description.
|
||||||
if (sim_->isWatchedStop(code) && !sim_->watched_stops[code].desc) {
|
if (sim_->isWatchedStop(code) && !sim_->watched_stops_[code].desc) {
|
||||||
sim_->watched_stops[code].desc = msg;
|
sim_->watched_stops_[code].desc = msg;
|
||||||
}
|
}
|
||||||
// Print the stop message and code if it is not the default code.
|
// Print the stop message and code if it is not the default code.
|
||||||
if (code != kMaxStopCode) {
|
if (code != kMaxStopCode) {
|
||||||
@ -1880,14 +1880,14 @@ bool Simulator::isEnabledStop(uint32_t code) {
|
|||||||
ASSERT(code <= kMaxStopCode);
|
ASSERT(code <= kMaxStopCode);
|
||||||
// Unwatched stops are always enabled.
|
// Unwatched stops are always enabled.
|
||||||
return !isWatchedStop(code) ||
|
return !isWatchedStop(code) ||
|
||||||
!(watched_stops[code].count & kStopDisabledBit);
|
!(watched_stops_[code].count & kStopDisabledBit);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
void Simulator::EnableStop(uint32_t code) {
|
void Simulator::EnableStop(uint32_t code) {
|
||||||
ASSERT(isWatchedStop(code));
|
ASSERT(isWatchedStop(code));
|
||||||
if (!isEnabledStop(code)) {
|
if (!isEnabledStop(code)) {
|
||||||
watched_stops[code].count &= ~kStopDisabledBit;
|
watched_stops_[code].count &= ~kStopDisabledBit;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -1895,7 +1895,7 @@ void Simulator::EnableStop(uint32_t code) {
|
|||||||
void Simulator::DisableStop(uint32_t code) {
|
void Simulator::DisableStop(uint32_t code) {
|
||||||
ASSERT(isWatchedStop(code));
|
ASSERT(isWatchedStop(code));
|
||||||
if (isEnabledStop(code)) {
|
if (isEnabledStop(code)) {
|
||||||
watched_stops[code].count |= kStopDisabledBit;
|
watched_stops_[code].count |= kStopDisabledBit;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -1903,13 +1903,13 @@ void Simulator::DisableStop(uint32_t code) {
|
|||||||
void Simulator::IncreaseStopCounter(uint32_t code) {
|
void Simulator::IncreaseStopCounter(uint32_t code) {
|
||||||
ASSERT(code <= kMaxStopCode);
|
ASSERT(code <= kMaxStopCode);
|
||||||
ASSERT(isWatchedStop(code));
|
ASSERT(isWatchedStop(code));
|
||||||
if ((watched_stops[code].count & ~(1 << 31)) == 0x7fffffff) {
|
if ((watched_stops_[code].count & ~(1 << 31)) == 0x7fffffff) {
|
||||||
PrintF("Stop counter for code %i has overflowed.\n"
|
PrintF("Stop counter for code %i has overflowed.\n"
|
||||||
"Enabling this code and reseting the counter to 0.\n", code);
|
"Enabling this code and reseting the counter to 0.\n", code);
|
||||||
watched_stops[code].count = 0;
|
watched_stops_[code].count = 0;
|
||||||
EnableStop(code);
|
EnableStop(code);
|
||||||
} else {
|
} else {
|
||||||
watched_stops[code].count++;
|
watched_stops_[code].count++;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -1921,12 +1921,12 @@ void Simulator::PrintStopInfo(uint32_t code) {
|
|||||||
PrintF("Stop not watched.");
|
PrintF("Stop not watched.");
|
||||||
} else {
|
} else {
|
||||||
const char* state = isEnabledStop(code) ? "Enabled" : "Disabled";
|
const char* state = isEnabledStop(code) ? "Enabled" : "Disabled";
|
||||||
int32_t count = watched_stops[code].count & ~kStopDisabledBit;
|
int32_t count = watched_stops_[code].count & ~kStopDisabledBit;
|
||||||
// Don't print the state of unused breakpoints.
|
// Don't print the state of unused breakpoints.
|
||||||
if (count != 0) {
|
if (count != 0) {
|
||||||
if (watched_stops[code].desc) {
|
if (watched_stops_[code].desc) {
|
||||||
PrintF("stop %i - 0x%x: \t%s, \tcounter = %i, \t%s\n",
|
PrintF("stop %i - 0x%x: \t%s, \tcounter = %i, \t%s\n",
|
||||||
code, code, state, count, watched_stops[code].desc);
|
code, code, state, count, watched_stops_[code].desc);
|
||||||
} else {
|
} else {
|
||||||
PrintF("stop %i - 0x%x: \t%s, \tcounter = %i\n",
|
PrintF("stop %i - 0x%x: \t%s, \tcounter = %i\n",
|
||||||
code, code, state, count);
|
code, code, state, count);
|
||||||
|
@ -414,14 +414,14 @@ class Simulator {
|
|||||||
static const uint32_t kStopDisabledBit = 1 << 31;
|
static const uint32_t kStopDisabledBit = 1 << 31;
|
||||||
|
|
||||||
// A stop is enabled, meaning the simulator will stop when meeting the
|
// A stop is enabled, meaning the simulator will stop when meeting the
|
||||||
// instruction, if bit 31 of watched_stops[code].count is unset.
|
// instruction, if bit 31 of watched_stops_[code].count is unset.
|
||||||
// The value watched_stops[code].count & ~(1 << 31) indicates how many times
|
// The value watched_stops_[code].count & ~(1 << 31) indicates how many times
|
||||||
// the breakpoint was hit or gone through.
|
// the breakpoint was hit or gone through.
|
||||||
struct StopCountAndDesc {
|
struct StopCountAndDesc {
|
||||||
uint32_t count;
|
uint32_t count;
|
||||||
char* desc;
|
char* desc;
|
||||||
};
|
};
|
||||||
StopCountAndDesc watched_stops[kNumOfWatchedStops];
|
StopCountAndDesc watched_stops_[kNumOfWatchedStops];
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
||||||
|
@ -132,8 +132,8 @@ void MipsDebugger::Stop(Instruction* instr) {
|
|||||||
ASSERT(msg != NULL);
|
ASSERT(msg != NULL);
|
||||||
|
|
||||||
// Update this stop description.
|
// Update this stop description.
|
||||||
if (!watched_stops[code].desc) {
|
if (!watched_stops_[code].desc) {
|
||||||
watched_stops[code].desc = msg;
|
watched_stops_[code].desc = msg;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (strlen(msg) > 0) {
|
if (strlen(msg) > 0) {
|
||||||
@ -163,8 +163,8 @@ void MipsDebugger::Stop(Instruction* instr) {
|
|||||||
char* msg = *reinterpret_cast<char**>(sim_->get_pc() +
|
char* msg = *reinterpret_cast<char**>(sim_->get_pc() +
|
||||||
Instruction::kInstrSize);
|
Instruction::kInstrSize);
|
||||||
// Update this stop description.
|
// Update this stop description.
|
||||||
if (!sim_->watched_stops[code].desc) {
|
if (!sim_->watched_stops_[code].desc) {
|
||||||
sim_->watched_stops[code].desc = msg;
|
sim_->watched_stops_[code].desc = msg;
|
||||||
}
|
}
|
||||||
PrintF("Simulator hit %s (%u)\n", msg, code);
|
PrintF("Simulator hit %s (%u)\n", msg, code);
|
||||||
sim_->set_pc(sim_->get_pc() + 2 * Instruction::kInstrSize);
|
sim_->set_pc(sim_->get_pc() + 2 * Instruction::kInstrSize);
|
||||||
@ -1636,33 +1636,33 @@ bool Simulator::IsStopInstruction(Instruction* instr) {
|
|||||||
bool Simulator::IsEnabledStop(uint32_t code) {
|
bool Simulator::IsEnabledStop(uint32_t code) {
|
||||||
ASSERT(code <= kMaxStopCode);
|
ASSERT(code <= kMaxStopCode);
|
||||||
ASSERT(code > kMaxWatchpointCode);
|
ASSERT(code > kMaxWatchpointCode);
|
||||||
return !(watched_stops[code].count & kStopDisabledBit);
|
return !(watched_stops_[code].count & kStopDisabledBit);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
void Simulator::EnableStop(uint32_t code) {
|
void Simulator::EnableStop(uint32_t code) {
|
||||||
if (!IsEnabledStop(code)) {
|
if (!IsEnabledStop(code)) {
|
||||||
watched_stops[code].count &= ~kStopDisabledBit;
|
watched_stops_[code].count &= ~kStopDisabledBit;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
void Simulator::DisableStop(uint32_t code) {
|
void Simulator::DisableStop(uint32_t code) {
|
||||||
if (IsEnabledStop(code)) {
|
if (IsEnabledStop(code)) {
|
||||||
watched_stops[code].count |= kStopDisabledBit;
|
watched_stops_[code].count |= kStopDisabledBit;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
void Simulator::IncreaseStopCounter(uint32_t code) {
|
void Simulator::IncreaseStopCounter(uint32_t code) {
|
||||||
ASSERT(code <= kMaxStopCode);
|
ASSERT(code <= kMaxStopCode);
|
||||||
if ((watched_stops[code].count & ~(1 << 31)) == 0x7fffffff) {
|
if ((watched_stops_[code].count & ~(1 << 31)) == 0x7fffffff) {
|
||||||
PrintF("Stop counter for code %i has overflowed.\n"
|
PrintF("Stop counter for code %i has overflowed.\n"
|
||||||
"Enabling this code and reseting the counter to 0.\n", code);
|
"Enabling this code and reseting the counter to 0.\n", code);
|
||||||
watched_stops[code].count = 0;
|
watched_stops_[code].count = 0;
|
||||||
EnableStop(code);
|
EnableStop(code);
|
||||||
} else {
|
} else {
|
||||||
watched_stops[code].count++;
|
watched_stops_[code].count++;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -1677,12 +1677,12 @@ void Simulator::PrintStopInfo(uint32_t code) {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
const char* state = IsEnabledStop(code) ? "Enabled" : "Disabled";
|
const char* state = IsEnabledStop(code) ? "Enabled" : "Disabled";
|
||||||
int32_t count = watched_stops[code].count & ~kStopDisabledBit;
|
int32_t count = watched_stops_[code].count & ~kStopDisabledBit;
|
||||||
// Don't print the state of unused breakpoints.
|
// Don't print the state of unused breakpoints.
|
||||||
if (count != 0) {
|
if (count != 0) {
|
||||||
if (watched_stops[code].desc) {
|
if (watched_stops_[code].desc) {
|
||||||
PrintF("stop %i - 0x%x: \t%s, \tcounter = %i, \t%s\n",
|
PrintF("stop %i - 0x%x: \t%s, \tcounter = %i, \t%s\n",
|
||||||
code, code, state, count, watched_stops[code].desc);
|
code, code, state, count, watched_stops_[code].desc);
|
||||||
} else {
|
} else {
|
||||||
PrintF("stop %i - 0x%x: \t%s, \tcounter = %i\n",
|
PrintF("stop %i - 0x%x: \t%s, \tcounter = %i\n",
|
||||||
code, code, state, count);
|
code, code, state, count);
|
||||||
|
@ -391,14 +391,14 @@ class Simulator {
|
|||||||
static const uint32_t kStopDisabledBit = 1 << 31;
|
static const uint32_t kStopDisabledBit = 1 << 31;
|
||||||
|
|
||||||
// A stop is enabled, meaning the simulator will stop when meeting the
|
// A stop is enabled, meaning the simulator will stop when meeting the
|
||||||
// instruction, if bit 31 of watched_stops[code].count is unset.
|
// instruction, if bit 31 of watched_stops_[code].count is unset.
|
||||||
// The value watched_stops[code].count & ~(1 << 31) indicates how many times
|
// The value watched_stops_[code].count & ~(1 << 31) indicates how many times
|
||||||
// the breakpoint was hit or gone through.
|
// the breakpoint was hit or gone through.
|
||||||
struct StopCountAndDesc {
|
struct StopCountAndDesc {
|
||||||
uint32_t count;
|
uint32_t count;
|
||||||
char* desc;
|
char* desc;
|
||||||
};
|
};
|
||||||
StopCountAndDesc watched_stops[kMaxStopCode + 1];
|
StopCountAndDesc watched_stops_[kMaxStopCode + 1];
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user