AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Improve graph visualizer for deoptimization and readablity.

Browse Source 
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/523593002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23582 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
sigurds@chromium.org 2014-09-02 08:44:25 +00:00
parent 2d1fe92b7f
commit de59be7cad
1 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/compiler/graph-visualizer.cc
View File

@ -33,7 +33,7 @@ class GraphVisualizer : public NullNodeVisitor {
private:
void AnnotateNode(Node* node);
void PrintEdge(Node* from, int index, Node* to);
void PrintEdge(Node::Edge edge);
Zone* zone_;
NodeSet all_nodes_;
@ -168,7 +168,7 @@ void GraphVisualizer::AnnotateNode(Node* node) {
}
for (int j = OperatorProperties::GetFrameStateInputCount(node->op()); j > 0;
++i, j--) {
os_ << "|<I" << i.index() << ">X #" << (*i)->id();
os_ << "|<I" << i.index() << ">F #" << (*i)->id();
}
for (int j = OperatorProperties::GetEffectInputCount(node->op()); j > 0;
++i, j--) {
@ -196,7 +196,10 @@ void GraphVisualizer::AnnotateNode(Node* node) {
}
void GraphVisualizer::PrintEdge(Node* from, int index, Node* to) {
void GraphVisualizer::PrintEdge(Node::Edge edge) {
Node* from = edge.from();
int index = edge.index();
Node* to = edge.to();
bool unconstrained = IsLikelyBackEdge(from, index, to);
os_ << " ID" << from->id();
if (all_nodes_.count(to) == 0) {
@ -205,11 +208,15 @@ void GraphVisualizer::PrintEdge(Node* from, int index, Node* to) {
GetControlCluster(from) == NULL ||
(OperatorProperties::GetControlInputCount(from->op()) > 0 &&
NodeProperties::GetControlInput(from) != to)) {
os_ << ":I" << index << ":n -> ID" << to->id() << ":s";
if (unconstrained) os_ << " [constraint=false,style=dotted]";
os_ << ":I" << index << ":n -> ID" << to->id() << ":s"
<< "[" << (unconstrained ? "constraint=false" : "")
<< (NodeProperties::IsControlEdge(edge) ? "style=bold" : "")
<< (NodeProperties::IsEffectEdge(edge) ? "style=dotted" : "")
<< (NodeProperties::IsContextEdge(edge) ? "style=dashed" : "") << "]";
} else {
os_ << " -> ID" << to->id() << ":s [color=transparent"
<< (unconstrained ? ", constraint=false" : "") << "]";
<< (unconstrained ? ", constraint=false" : "")
<< (NodeProperties::IsControlEdge(edge) ? ", style=dashed" : "") << "]";
}
os_ << "\n";
}
@ -219,6 +226,10 @@ void GraphVisualizer::Print() {
os_ << "digraph D {\n"
<< " node [fontsize=8,height=0.25]\n"
<< " rankdir=\"BT\"\n"
<< " ranksep=\"1.2 equally\"\n"
<< " overlap=\"false\"\n"
<< " splines=\"true\"\n"
<< " concentrate=\"true\"\n"
<< " \n";
// Make sure all nodes have been output before writing out the edges.
@ -244,7 +255,7 @@ void GraphVisualizer::Print() {
Node::Inputs inputs = (*i)->inputs();
for (Node::Inputs::iterator iter(inputs.begin()); iter != inputs.end();
++iter) {
PrintEdge(iter.edge().from(), iter.edge().index(), iter.edge().to());
PrintEdge(iter.edge());
}
}
os_ << "}\n";