AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Disable embedded builtins

Browse Source 
Embedded builtins have been regressing benchmarks incrementally as
more and more builtins were moved to the embedded blob. This has made
recognition and analysis of other possible performance issues more
difficult.

Let's disable embedded builtins until their performance is at an
acceptable level.

Bug: v8:6666
Change-Id: I21a1274f3d5a65063127b0a8604df6dd0d3c0c95
Reviewed-on: https://chromium-review.googlesource.com/1049550
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53062}
This commit is contained in:
jgruber 2018-05-08 12:42:08 +02:00 committed by Commit Bot
parent 855850eb7f
commit e0c3f6d6ca
4 changed files with 38 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
BUILD.gn
View File

@ -70,7 +70,8 @@ declare_args() {
# Enable embedded builtins.
# TODO(jgruber,v8:6666): Support ia32 and maybe MSVC.
v8_enable_embedded_builtins = v8_current_cpu != "x86" && (!is_win || is_clang)
# TODO(jgruber,v8:6666): Re-enable.
v8_enable_embedded_builtins = false
# Enable code-generation-time checking of types in the CodeStubAssembler.
v8_enable_verify_csa = false

9
infra/mb/mb_config.pyl
View File

@ -417,7 +417,8 @@
'release_x64_gcc_coverage': [
'release_bot', 'x64', 'coverage', 'gcc'],
'release_x64_internal': [
'release_bot', 'x64', 'v8_snapshot_internal'],
'release_bot', 'x64', 'v8_enable_embedded_builtins',
'v8_snapshot_internal'],
'release_x64_jumbo': [
'release_bot', 'x64', 'jumbo'],
'release_x64_jumbo_trybot': [
@ -451,7 +452,7 @@
'release_bot', 'x64', 'ubsan_vptr', 'minimal_symbols'],
'release_x64_verify_csa': [
'release_bot', 'x64', 'dcheck_always_on',
'v8_enable_slow_dchecks', 'v8_verify_csa'],
'v8_enable_slow_dchecks', 'v8_enable_embedded_builtins', 'v8_verify_csa'],
# Debug configs for x64.
'debug_x64': [
@ -758,6 +759,10 @@
'gn_args': 'v8_correctness_fuzzer=true v8_multi_arch_build=true',
},
'v8_enable_embedded_builtins': {
'gn_args': 'v8_enable_embedded_builtins=true',
},
'v8_enable_slow_dchecks': {
'gn_args': 'v8_enable_slow_dchecks=true',
},

3
test/mkgrokdump/mkgrokdump.cc
View File

@ -28,7 +28,8 @@ static const char* kHeader =
// Non-snapshot builds allocate objects to different places.
// Debug builds emit debug code, affecting code object sizes.
// Embedded builtins cause objects to be allocated in different locations.
#if defined(V8_EMBEDDED_BUILTINS) && defined(V8_USE_SNAPSHOT) && !defined(DEBUG)
#if !defined(V8_EMBEDDED_BUILTINS) && defined(V8_USE_SNAPSHOT) && \
!defined(DEBUG)
static const char* kBuild = "shipping";
#else
static const char* kBuild = "non-shipping";

54
tools/v8heapconst.py
View File

@ -265,33 +265,33 @@ KNOWN_MAPS = {
("RO_SPACE", 0x04ee9): (172, "Tuple2Map"),
("RO_SPACE", 0x04f61): (170, "ScriptMap"),
("RO_SPACE", 0x04fc9): (162, "InterceptorInfoMap"),
("RO_SPACE", 0x08ec1): (154, "AccessorInfoMap"),
("RO_SPACE", 0x090d1): (153, "AccessCheckInfoMap"),
("RO_SPACE", 0x09139): (155, "AccessorPairMap"),
("RO_SPACE", 0x091a1): (156, "AliasedArgumentsEntryMap"),
("RO_SPACE", 0x09209): (157, "AllocationMementoMap"),
("RO_SPACE", 0x09271): (158, "AllocationSiteMap"),
("RO_SPACE", 0x092d9): (159, "AsyncGeneratorRequestMap"),
("RO_SPACE", 0x09341): (160, "DebugInfoMap"),
("RO_SPACE", 0x093a9): (161, "FunctionTemplateInfoMap"),
("RO_SPACE", 0x09411): (163, "InterpreterDataMap"),
("RO_SPACE", 0x09479): (164, "ModuleInfoEntryMap"),
("RO_SPACE", 0x094e1): (165, "ModuleMap"),
("RO_SPACE", 0x09549): (166, "ObjectTemplateInfoMap"),
("RO_SPACE", 0x095b1): (167, "PromiseCapabilityMap"),
("RO_SPACE", 0x09619): (168, "PromiseReactionMap"),
("RO_SPACE", 0x09681): (169, "PrototypeInfoMap"),
("RO_SPACE", 0x096e9): (171, "StackFrameInfoMap"),
("RO_SPACE", 0x09751): (173, "Tuple3Map"),
("RO_SPACE", 0x097b9): (174, "WasmCompiledModuleMap"),
("RO_SPACE", 0x09821): (175, "WasmDebugInfoMap"),
("RO_SPACE", 0x09889): (176, "WasmExportedFunctionDataMap"),
("RO_SPACE", 0x098f1): (177, "WasmSharedModuleDataMap"),
("RO_SPACE", 0x09959): (178, "CallableTaskMap"),
("RO_SPACE", 0x099c1): (179, "CallbackTaskMap"),
("RO_SPACE", 0x09a29): (180, "PromiseFulfillReactionJobTaskMap"),
("RO_SPACE", 0x09a91): (181, "PromiseRejectReactionJobTaskMap"),
("RO_SPACE", 0x09af9): (182, "PromiseResolveThenableJobTaskMap"),
("RO_SPACE", 0x06ec9): (154, "AccessorInfoMap"),
("RO_SPACE", 0x070d9): (153, "AccessCheckInfoMap"),
("RO_SPACE", 0x07141): (155, "AccessorPairMap"),
("RO_SPACE", 0x071a9): (156, "AliasedArgumentsEntryMap"),
("RO_SPACE", 0x07211): (157, "AllocationMementoMap"),
("RO_SPACE", 0x07279): (158, "AllocationSiteMap"),
("RO_SPACE", 0x072e1): (159, "AsyncGeneratorRequestMap"),
("RO_SPACE", 0x07349): (160, "DebugInfoMap"),
("RO_SPACE", 0x073b1): (161, "FunctionTemplateInfoMap"),
("RO_SPACE", 0x07419): (163, "InterpreterDataMap"),
("RO_SPACE", 0x07481): (164, "ModuleInfoEntryMap"),
("RO_SPACE", 0x074e9): (165, "ModuleMap"),
("RO_SPACE", 0x07551): (166, "ObjectTemplateInfoMap"),
("RO_SPACE", 0x075b9): (167, "PromiseCapabilityMap"),
("RO_SPACE", 0x07621): (168, "PromiseReactionMap"),
("RO_SPACE", 0x07689): (169, "PrototypeInfoMap"),
("RO_SPACE", 0x076f1): (171, "StackFrameInfoMap"),
("RO_SPACE", 0x07759): (173, "Tuple3Map"),
("RO_SPACE", 0x077c1): (174, "WasmCompiledModuleMap"),
("RO_SPACE", 0x07829): (175, "WasmDebugInfoMap"),
("RO_SPACE", 0x07891): (176, "WasmExportedFunctionDataMap"),
("RO_SPACE", 0x078f9): (177, "WasmSharedModuleDataMap"),
("RO_SPACE", 0x07961): (178, "CallableTaskMap"),
("RO_SPACE", 0x079c9): (179, "CallbackTaskMap"),
("RO_SPACE", 0x07a31): (180, "PromiseFulfillReactionJobTaskMap"),
("RO_SPACE", 0x07a99): (181, "PromiseRejectReactionJobTaskMap"),
("RO_SPACE", 0x07b01): (182, "PromiseResolveThenableJobTaskMap"),
("MAP_SPACE", 0x02201): (1057, "ExternalMap"),
("MAP_SPACE", 0x02259): (1072, "JSMessageObjectMap"),
}