AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix 'combo breaker' in CreateDynamicFunction to handle template literals.

Browse Source 
BUG=chromium:663410

Review-Url: https://codereview.chromium.org/2533463002
Cr-Commit-Position: refs/heads/master@{#41320}
This commit is contained in:
vogelheim 2016-11-28 06:43:35 -08:00 committed by Commit bot
parent 54aac1f778
commit e0d608a2b1
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/builtins/builtins-function.cc
View File

@ -61,7 +61,7 @@ MaybeHandle<Object> CreateDynamicFunction(Isolate* isolate,
// If the formal parameters include an unbalanced block comment, the
// function must be rejected. Since JavaScript does not allow nested
// comments we can include a trailing block comment to catch this.
builder.AppendCString("\n/**/");
builder.AppendCString("\n/*``*/");
}
builder.AppendCString(") {\n");
if (argc > 0) {

8
test/mjsunit/regress-crbug-663410.js Normal file
View File

@ -0,0 +1,8 @@
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
function alert(x) {};
assertThrows(
Function("a=`","`,xss=1){alert(xss)")
);