From e0d7681e31746df4e23ec326d6eb5ff046d4596a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20Gro=C3=9F?= Date: Mon, 6 Feb 2023 15:39:35 +0100 Subject: [PATCH] Remove negative flag implication for --experimental MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The conflict with --future causes tests that enable experimental features to fail if the test configuration enables --future, and the conflict with --fuzzing makes it impossible to reproduce issues in Clusterfuzz as it always adds --fuzzing to the commandline. Change-Id: I7d952fc5c09967386e06d992b4dbd6129ea404c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4224454 Reviewed-by: Leszek Swirski Commit-Queue: Samuel Groß Cr-Commit-Position: refs/heads/main@{#85684} --- src/flags/flag-definitions.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index 14a4a272a9..7f216bea0d 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -199,10 +199,6 @@ DEFINE_BOOL(experimental, false, "Indicates that V8 is running with experimental features enabled. " "This flag is typically not set explicitly but instead enabled as " "an implication of other flags which enable experimental features.") -// Features considered experimental should not be staged behind --future. -DEFINE_NEG_IMPLICATION(future, experimental) -// Features considered experimental are not ready for fuzzing. -DEFINE_NEG_IMPLICATION(fuzzing, experimental) #define DEFINE_EXPERIMENTAL_FEATURE(nam, cmt) \ FLAG(BOOL, bool, nam, false, cmt " (experimental)") \ DEFINE_IMPLICATION(nam, experimental)