AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Remove obsolete frame-state from count op.

Browse Source 
This removes the usage of {FrameStateBeforeAndAfter} from the graph
building for count operations. The {JSAdd} or {JSSubtract} node in
question no longer needs the frame-state attached.

R=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2127523002
Cr-Commit-Position: refs/heads/master@{#37529}
This commit is contained in:
mstarzinger 2016-07-05 05:41:25 -07:00 committed by Commit bot
parent d70dc1ace4
commit e0dd3119e0
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/compiler/ast-graph-builder.cc
View File

@ -2695,7 +2695,7 @@ void AstGraphBuilder::VisitCountOperation(CountOperation* expr) {
// Create a proper eager frame state for the stores.
environment()->Push(old_value);
FrameStateBeforeAndAfter binop_states(this, expr->ToNumberId());
PrepareEagerCheckpoint(expr->ToNumberId());
old_value = environment()->Pop();
// Save result for postfix expressions at correct stack depth.
@ -2708,12 +2708,10 @@ void AstGraphBuilder::VisitCountOperation(CountOperation* expr) {
}
// Create node to perform +1/-1 operation.
// TODO(bmeurer): Cleanup this feedback/bailout mess!
Node* value = BuildBinaryOp(old_value, jsgraph()->OneConstant(),
expr->binary_op(), expr->CountBinOpFeedbackId());
// This should never deoptimize because we have converted to number before.
binop_states.AddToNode(value, BailoutId::None(),
OutputFrameStateCombine::Ignore());
// This should never lazy deopt because we have converted to number before.
PrepareFrameState(value, BailoutId::None());
// Store the value.
VectorSlotPair feedback = CreateVectorSlotPair(expr->CountSlot());