AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Add missing NOLINT annotations

Browse Source 
Due to a rebase, those annotations were missing in
https://crrev.com/c/1687891.

TBR=mlippautz@chromium.org

Bug: v8:9429
Change-Id: I78ff2903dbbe1054499d4768e9ff5fb0c5f4b708
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690826
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62552}
This commit is contained in:
Clemens Hammacher 2019-07-08 12:11:37 +02:00 committed by Commit Bot
parent 8e11cc395a
commit e0e076c044
2 changed files with 20 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/objects/stack-frame-info.cc
View File

@ -286,8 +286,10 @@ void AppendMethodCall(Isolate* isolate, Handle<StackTraceFrame> frame,
}
}
void SerializeJSStackFrame(Isolate* isolate, Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder) {
void SerializeJSStackFrame(
Isolate* isolate, Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder // NOLINT(runtime/references)
) {
Handle<Object> function_name = StackTraceFrame::GetFunctionName(frame);
const bool is_toplevel = StackTraceFrame::IsToplevel(frame);
@ -330,9 +332,10 @@ void SerializeJSStackFrame(Isolate* isolate, Handle<StackTraceFrame> frame,
builder.AppendCString(")");
}
void SerializeAsmJsWasmStackFrame(Isolate* isolate,
Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder) {
void SerializeAsmJsWasmStackFrame(
Isolate* isolate, Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder // NOLINT(runtime/references)
) {
// The string should look exactly as the respective javascript frame string.
// Keep this method in line to
// JSStackFrame::ToString(IncrementalStringBuilder&).
@ -350,8 +353,10 @@ void SerializeAsmJsWasmStackFrame(Isolate* isolate,
return;
}
void SerializeWasmStackFrame(Isolate* isolate, Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder) {
void SerializeWasmStackFrame(
Isolate* isolate, Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder // NOLINT(runtime/references)
) {
Handle<Object> module_name = StackTraceFrame::GetWasmModuleName(frame);
Handle<Object> function_name = StackTraceFrame::GetFunctionName(frame);
const bool has_name = !module_name->IsNull() || !function_name->IsNull();
@ -384,8 +389,10 @@ void SerializeWasmStackFrame(Isolate* isolate, Handle<StackTraceFrame> frame,
} // namespace
void SerializeStackTraceFrame(Isolate* isolate, Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder) {
void SerializeStackTraceFrame(
Isolate* isolate, Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder // NOLINT(runtime/references)
) {
// Ordering here is important, as AsmJs frames are also marked as Wasm.
if (StackTraceFrame::IsAsmJsWasm(frame)) {
SerializeAsmJsWasmStackFrame(isolate, frame, builder);

6
src/objects/stack-frame-info.h
View File

@ -124,8 +124,10 @@ Handle<FrameArray> GetFrameArrayFromStackTrace(Isolate* isolate,
Handle<FixedArray> stack_trace);
class IncrementalStringBuilder;
void SerializeStackTraceFrame(Isolate* isolate, Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder);
void SerializeStackTraceFrame(
Isolate* isolate, Handle<StackTraceFrame> frame,
IncrementalStringBuilder& builder // NOLINT(runtime/references)
);
MaybeHandle<String> SerializeStackTraceFrame(Isolate* isolate,
Handle<StackTraceFrame> frame);