AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix coverage build for bytecode_builtins_list_generator

Browse Source 
Use v8_executable instead of executable for
bytecode_builtins_list_generator so that coverage link flags should be
picked up too.

Bug: v8:8068
Change-Id: I260e4de3485a78d3b3a3455441837e1a5936aa25
Reviewed-on: https://chromium-review.googlesource.com/1219326
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55787}
This commit is contained in:
Dan Elphick 2018-09-11 11:27:03 +01:00 committed by Commit Bot
parent c995a1dcd6
commit e0e9461fab
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
BUILD.gn
View File

@ -3285,7 +3285,7 @@ if (v8_monolithic) {
#
if (current_toolchain == host_toolchain) {
executable("bytecode_builtins_list_generator") {
v8_executable("bytecode_builtins_list_generator") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
include_dirs = [ "." ]
@ -3302,6 +3302,8 @@ if (current_toolchain == host_toolchain) {
defines = [ "V8_EMBEDDED_BUILTINS" ]
}
configs = [ ":internal_config" ]
deps = [
":v8_libbase",
"//build/win:default_exe_manifest",