diff --git a/SConstruct b/SConstruct index dcde82689d..c85ae1ae80 100644 --- a/SConstruct +++ b/SConstruct @@ -111,8 +111,8 @@ ANDROID_LINKFLAGS = ['-nostdlib', LIBRARY_FLAGS = { 'all': { 'CPPPATH': [join(root_dir, 'src')], - 'regexp:native': { - 'CPPDEFINES': ['V8_NATIVE_REGEXP'] + 'regexp:interpreted': { + 'CPPDEFINES': ['V8_INTERPRETED_REGEXP'] }, 'mode:debug': { 'CPPDEFINES': ['V8_ENABLE_CHECKS'] diff --git a/src/arm/regexp-macro-assembler-arm.cc b/src/arm/regexp-macro-assembler-arm.cc index 309340229b..2fdba14af4 100644 --- a/src/arm/regexp-macro-assembler-arm.cc +++ b/src/arm/regexp-macro-assembler-arm.cc @@ -39,7 +39,7 @@ namespace v8 { namespace internal { -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP /* * This assembler uses the following register assignment convention * - r5 : Pointer to current code object (Code*) including heap object tag. @@ -1235,6 +1235,6 @@ void RegExpCEntryStub::Generate(MacroAssembler* masm_) { #undef __ -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP }} // namespace v8::internal diff --git a/src/arm/regexp-macro-assembler-arm.h b/src/arm/regexp-macro-assembler-arm.h index ef54388029..2c0a8d84d4 100644 --- a/src/arm/regexp-macro-assembler-arm.h +++ b/src/arm/regexp-macro-assembler-arm.h @@ -32,14 +32,14 @@ namespace v8 { namespace internal { -#ifndef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP class RegExpMacroAssemblerARM: public RegExpMacroAssembler { public: RegExpMacroAssemblerARM(); virtual ~RegExpMacroAssemblerARM(); }; -#else +#else // V8_INTERPRETED_REGEXP class RegExpMacroAssemblerARM: public NativeRegExpMacroAssembler { public: RegExpMacroAssemblerARM(Mode mode, int registers_to_save); @@ -258,7 +258,7 @@ class RegExpCEntryStub: public CodeStub { const char* GetName() { return "RegExpCEntryStub"; } }; -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP }} // namespace v8::internal diff --git a/src/arm/simulator-arm.cc b/src/arm/simulator-arm.cc index a9f39f1bad..827a88f356 100644 --- a/src/arm/simulator-arm.cc +++ b/src/arm/simulator-arm.cc @@ -2539,4 +2539,4 @@ uintptr_t Simulator::PopAddress() { } } // namespace assembler::arm -#endif // !defined(__arm__) +#endif // __arm__ diff --git a/src/assembler.cc b/src/assembler.cc index ac27a656ec..ac03c200c2 100644 --- a/src/assembler.cc +++ b/src/assembler.cc @@ -46,7 +46,7 @@ #include "regexp-macro-assembler.h" #include "platform.h" // Include native regexp-macro-assembler. -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP #if V8_TARGET_ARCH_IA32 #include "ia32/regexp-macro-assembler-ia32.h" #elif V8_TARGET_ARCH_X64 @@ -56,7 +56,7 @@ #else // Unknown architecture. #error "Unknown architecture." #endif // Target architecture. -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP namespace v8 { namespace internal { @@ -680,7 +680,7 @@ ExternalReference ExternalReference::compile_array_push_call() { } -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP ExternalReference ExternalReference::re_check_stack_guard_state() { Address function; @@ -723,7 +723,7 @@ ExternalReference ExternalReference::address_of_regexp_stack_memory_size() { return ExternalReference(RegExpStack::memory_size_address()); } -#endif +#endif // V8_INTERPRETED_REGEXP static double add_two_doubles(double x, double y) { diff --git a/src/assembler.h b/src/assembler.h index 31ac44c841..03a2f8ea1c 100644 --- a/src/assembler.h +++ b/src/assembler.h @@ -457,7 +457,7 @@ class ExternalReference BASE_EMBEDDED { static ExternalReference debug_step_in_fp_address(); #endif -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP // C functions called from RegExp generated code. // Function NativeRegExpMacroAssembler::CaseInsensitiveCompareUC16() diff --git a/src/heap.cc b/src/heap.cc index 48c73bf676..eb478846a3 100644 --- a/src/heap.cc +++ b/src/heap.cc @@ -41,7 +41,7 @@ #include "scopeinfo.h" #include "snapshot.h" #include "v8threads.h" -#if V8_TARGET_ARCH_ARM && V8_NATIVE_REGEXP +#if V8_TARGET_ARCH_ARM && !V8_INTERPRETED_REGEXP #include "regexp-macro-assembler.h" #include "arm/regexp-macro-assembler-arm.h" #endif @@ -1527,7 +1527,7 @@ void Heap::CreateCEntryStub() { } -#if V8_TARGET_ARCH_ARM && V8_NATIVE_REGEXP +#if V8_TARGET_ARCH_ARM && !V8_INTERPRETED_REGEXP void Heap::CreateRegExpCEntryStub() { RegExpCEntryStub stub; set_re_c_entry_code(*stub.GetCode()); @@ -1564,7 +1564,7 @@ void Heap::CreateFixedStubs() { Heap::CreateCEntryStub(); Heap::CreateJSEntryStub(); Heap::CreateJSConstructEntryStub(); -#if V8_TARGET_ARCH_ARM && V8_NATIVE_REGEXP +#if V8_TARGET_ARCH_ARM && !V8_INTERPRETED_REGEXP Heap::CreateRegExpCEntryStub(); #endif } diff --git a/src/heap.h b/src/heap.h index 4812bd9de8..6661b5db6f 100644 --- a/src/heap.h +++ b/src/heap.h @@ -110,7 +110,7 @@ class ZoneScopeInfo; V(Script, empty_script, EmptyScript) \ V(Smi, real_stack_limit, RealStackLimit) \ -#if V8_TARGET_ARCH_ARM && V8_NATIVE_REGEXP +#if V8_TARGET_ARCH_ARM && !V8_INTERPRETED_REGEXP #define STRONG_ROOT_LIST(V) \ UNCONDITIONAL_STRONG_ROOT_LIST(V) \ V(Code, re_c_entry_code, RegExpCEntryCode) diff --git a/src/ia32/codegen-ia32.cc b/src/ia32/codegen-ia32.cc index 7682d57e0c..9512886a58 100644 --- a/src/ia32/codegen-ia32.cc +++ b/src/ia32/codegen-ia32.cc @@ -10808,9 +10808,9 @@ void RegExpExecStub::Generate(MacroAssembler* masm) { // Just jump directly to runtime if native RegExp is not selected at compile // time or if regexp entry in generated code is turned off runtime switch or // at compilation. -#ifndef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); -#else // V8_NATIVE_REGEXP +#else // V8_INTERPRETED_REGEXP if (!FLAG_regexp_entry_native) { __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); return; @@ -11127,7 +11127,7 @@ void RegExpExecStub::Generate(MacroAssembler* masm) { // Do the runtime call to execute the regexp. __ bind(&runtime); __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP } diff --git a/src/ia32/regexp-macro-assembler-ia32.cc b/src/ia32/regexp-macro-assembler-ia32.cc index 7e82528c9d..10dcb6aeed 100644 --- a/src/ia32/regexp-macro-assembler-ia32.cc +++ b/src/ia32/regexp-macro-assembler-ia32.cc @@ -38,7 +38,7 @@ namespace v8 { namespace internal { -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP /* * This assembler uses the following register assignment convention * - edx : current character. Must be loaded using LoadCurrentCharacter @@ -1195,6 +1195,6 @@ void RegExpMacroAssemblerIA32::LoadCurrentCharacterUnchecked(int cp_offset, #undef __ -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP }} // namespace v8::internal diff --git a/src/ia32/regexp-macro-assembler-ia32.h b/src/ia32/regexp-macro-assembler-ia32.h index 0d5e272dcf..823bc03312 100644 --- a/src/ia32/regexp-macro-assembler-ia32.h +++ b/src/ia32/regexp-macro-assembler-ia32.h @@ -31,14 +31,14 @@ namespace v8 { namespace internal { -#ifndef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP class RegExpMacroAssemblerIA32: public RegExpMacroAssembler { public: RegExpMacroAssemblerIA32() { } virtual ~RegExpMacroAssemblerIA32() { } }; -#else +#else // V8_INTERPRETED_REGEXP class RegExpMacroAssemblerIA32: public NativeRegExpMacroAssembler { public: RegExpMacroAssemblerIA32(Mode mode, int registers_to_save); @@ -208,7 +208,7 @@ class RegExpMacroAssemblerIA32: public NativeRegExpMacroAssembler { Label check_preempt_label_; Label stack_overflow_label_; }; -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP }} // namespace v8::internal diff --git a/src/jsregexp.cc b/src/jsregexp.cc index 5cace72bdd..0ae8bd34df 100644 --- a/src/jsregexp.cc +++ b/src/jsregexp.cc @@ -43,7 +43,7 @@ #include "regexp-macro-assembler-irregexp.h" #include "regexp-stack.h" -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP #if V8_TARGET_ARCH_IA32 #include "ia32/regexp-macro-assembler-ia32.h" #elif V8_TARGET_ARCH_X64 @@ -236,10 +236,10 @@ Handle RegExpImpl::AtomExec(Handle re, // returns false. bool RegExpImpl::EnsureCompiledIrregexp(Handle re, bool is_ascii) { Object* compiled_code = re->DataAt(JSRegExp::code_index(is_ascii)); -#ifdef V8_NATIVE_REGEXP - if (compiled_code->IsCode()) return true; -#else // ! V8_NATIVE_REGEXP (RegExp interpreter code) +#ifdef V8_INTERPRETED_REGEXP if (compiled_code->IsByteArray()) return true; +#else // V8_INTERPRETED_REGEXP (RegExp native code) + if (compiled_code->IsCode()) return true; #endif return CompileIrregexp(re, is_ascii); } @@ -360,14 +360,14 @@ int RegExpImpl::IrregexpPrepare(Handle regexp, if (!EnsureCompiledIrregexp(regexp, is_ascii)) { return -1; } -#ifdef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP + // Byte-code regexp needs space allocated for all its registers. + return IrregexpNumberOfRegisters(FixedArray::cast(regexp->data())); +#else // V8_INTERPRETED_REGEXP // Native regexp only needs room to output captures. Registers are handled // internally. return (IrregexpNumberOfCaptures(FixedArray::cast(regexp->data())) + 1) * 2; -#else // !V8_NATIVE_REGEXP - // Byte-code regexp needs space allocated for all its registers. - return IrregexpNumberOfRegisters(FixedArray::cast(regexp->data())); -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP } @@ -381,7 +381,7 @@ RegExpImpl::IrregexpResult RegExpImpl::IrregexpExecOnce(Handle regexp, ASSERT(index <= subject->length()); ASSERT(subject->IsFlat()); -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP ASSERT(output.length() >= (IrregexpNumberOfCaptures(*irregexp) + 1) * 2); do { @@ -414,7 +414,7 @@ RegExpImpl::IrregexpResult RegExpImpl::IrregexpExecOnce(Handle regexp, } while (true); UNREACHABLE(); return RE_EXCEPTION; -#else // ndef V8_NATIVE_REGEXP +#else // V8_INTERPRETED_REGEXP ASSERT(output.length() >= IrregexpNumberOfRegisters(*irregexp)); bool is_ascii = subject->IsAsciiRepresentation(); @@ -435,7 +435,7 @@ RegExpImpl::IrregexpResult RegExpImpl::IrregexpExecOnce(Handle regexp, return RE_SUCCESS; } return RE_FAILURE; -#endif // ndef V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP } @@ -446,7 +446,7 @@ Handle RegExpImpl::IrregexpExec(Handle jsregexp, ASSERT_EQ(jsregexp->TypeTag(), JSRegExp::IRREGEXP); // Prepare space for the return values. -#ifndef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP #ifdef DEBUG if (FLAG_trace_regexp_bytecodes) { String* pattern = jsregexp->Pattern(); @@ -5232,7 +5232,7 @@ RegExpEngine::CompilationResult RegExpEngine::Compile(RegExpCompileData* data, NodeInfo info = *node->info(); // Create the correct assembler for the architecture. -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP // Native regexp implementation. NativeRegExpMacroAssembler::Mode mode = @@ -5247,11 +5247,11 @@ RegExpEngine::CompilationResult RegExpEngine::Compile(RegExpCompileData* data, RegExpMacroAssemblerARM macro_assembler(mode, (data->capture_count + 1) * 2); #endif -#else // ! V8_NATIVE_REGEXP +#else // V8_INTERPRETED_REGEXP // Interpreted regexp implementation. EmbeddedVector codes; RegExpMacroAssemblerIrregexp macro_assembler(codes); -#endif +#endif // V8_INTERPRETED_REGEXP return compiler.Assemble(¯o_assembler, node, diff --git a/src/jsregexp.h b/src/jsregexp.h index 8f01342616..f6d511f697 100644 --- a/src/jsregexp.h +++ b/src/jsregexp.h @@ -42,10 +42,10 @@ class RegExpImpl { public: // Whether V8 is compiled with native regexp support or not. static bool UsesNativeRegExp() { -#ifdef V8_NATIVE_REGEXP - return true; -#else +#ifdef V8_INTERPRETED_REGEXP return false; +#else + return true; #endif } diff --git a/src/mips/simulator-mips.cc b/src/mips/simulator-mips.cc index e2280d3d34..bdb3b7f3bc 100644 --- a/src/mips/simulator-mips.cc +++ b/src/mips/simulator-mips.cc @@ -139,7 +139,7 @@ void Debugger::Stop(Instruction* instr) { sim_->set_pc(sim_->get_pc() + Instruction::kInstructionSize); Debug(); } -#endif // def GENERATED_CODE_COVERAGE +#endif // GENERATED_CODE_COVERAGE int32_t Debugger::GetRegisterValue(int regnum) { @@ -1644,5 +1644,5 @@ uintptr_t Simulator::PopAddress() { } } // namespace assembler::mips -#endif // !defined(__mips) +#endif // __mips diff --git a/src/regexp-macro-assembler-irregexp-inl.h b/src/regexp-macro-assembler-irregexp-inl.h index b487468eff..f2a4e851f7 100644 --- a/src/regexp-macro-assembler-irregexp-inl.h +++ b/src/regexp-macro-assembler-irregexp-inl.h @@ -38,7 +38,7 @@ namespace v8 { namespace internal { -#ifndef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP void RegExpMacroAssemblerIrregexp::Emit(uint32_t byte, uint32_t twenty_four_bits) { @@ -71,7 +71,7 @@ void RegExpMacroAssemblerIrregexp::Emit32(uint32_t word) { pc_ += 4; } -#endif // ! V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP } } // namespace v8::internal diff --git a/src/regexp-macro-assembler-irregexp.cc b/src/regexp-macro-assembler-irregexp.cc index f9c7eeee01..90abe912fa 100644 --- a/src/regexp-macro-assembler-irregexp.cc +++ b/src/regexp-macro-assembler-irregexp.cc @@ -36,7 +36,7 @@ namespace v8 { namespace internal { -#ifndef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP RegExpMacroAssemblerIrregexp::RegExpMacroAssemblerIrregexp(Vector buffer) : buffer_(buffer), @@ -459,6 +459,6 @@ void RegExpMacroAssemblerIrregexp::Expand() { } } -#endif // !V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP } } // namespace v8::internal diff --git a/src/regexp-macro-assembler-irregexp.h b/src/regexp-macro-assembler-irregexp.h index 642a283907..3ddbc2fe2d 100644 --- a/src/regexp-macro-assembler-irregexp.h +++ b/src/regexp-macro-assembler-irregexp.h @@ -31,7 +31,7 @@ namespace v8 { namespace internal { -#ifndef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP class RegExpMacroAssemblerIrregexp: public RegExpMacroAssembler { public: @@ -134,7 +134,7 @@ class RegExpMacroAssemblerIrregexp: public RegExpMacroAssembler { DISALLOW_IMPLICIT_CONSTRUCTORS(RegExpMacroAssemblerIrregexp); }; -#endif // !V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP } } // namespace v8::internal diff --git a/src/regexp-macro-assembler.cc b/src/regexp-macro-assembler.cc index 0fcfc33d75..fc6594759c 100644 --- a/src/regexp-macro-assembler.cc +++ b/src/regexp-macro-assembler.cc @@ -52,7 +52,7 @@ bool RegExpMacroAssembler::CanReadUnaligned() { } -#ifdef V8_NATIVE_REGEXP // Avoid unused code, e.g., on ARM. +#ifndef V8_INTERPRETED_REGEXP // Avoid unused code, e.g., on ARM. NativeRegExpMacroAssembler::NativeRegExpMacroAssembler() { } @@ -258,5 +258,6 @@ Address NativeRegExpMacroAssembler::GrowStack(Address stack_pointer, return new_stack_base - stack_content_size; } -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP + } } // namespace v8::internal diff --git a/src/regexp-macro-assembler.h b/src/regexp-macro-assembler.h index 105d8cc489..9f8e2c5c81 100644 --- a/src/regexp-macro-assembler.h +++ b/src/regexp-macro-assembler.h @@ -161,7 +161,7 @@ class RegExpMacroAssembler { }; -#ifdef V8_NATIVE_REGEXP // Avoid compiling unused code. +#ifndef V8_INTERPRETED_REGEXP // Avoid compiling unused code. class NativeRegExpMacroAssembler: public RegExpMacroAssembler { public: @@ -221,7 +221,7 @@ class NativeRegExpMacroAssembler: public RegExpMacroAssembler { int* output); }; -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP } } // namespace v8::internal diff --git a/src/serialize.cc b/src/serialize.cc index 9b18a08852..1c0b7312bc 100644 --- a/src/serialize.cc +++ b/src/serialize.cc @@ -422,7 +422,7 @@ void ExternalReferenceTable::PopulateTable() { UNCLASSIFIED, 21, "compile_array_push"); -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP Add(ExternalReference::re_case_insensitive_compare_uc16().address(), UNCLASSIFIED, 22, @@ -439,7 +439,7 @@ void ExternalReferenceTable::PopulateTable() { UNCLASSIFIED, 25, "NativeRegExpMacroAssembler::word_character_map"); -#endif +#endif // V8_INTERPRETED_REGEXP // Keyed lookup cache. Add(ExternalReference::keyed_lookup_cache_keys().address(), UNCLASSIFIED, diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc index 6d332b7091..c55a4ea576 100644 --- a/src/x64/builtins-x64.cc +++ b/src/x64/builtins-x64.cc @@ -1212,7 +1212,7 @@ static void Generate_JSEntryTrampolineHelper(MacroAssembler* masm, __ movq(rbx, Operand(kScratchRegister, EntryFrameConstants::kArgvOffset)); // Load the function pointer into rdi. __ movq(rdi, rdx); -#else // !defined(_WIN64) +#else // _WIN64 // GCC parameters in: // rdi : entry (ignored) // rsi : function diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc index 44d7ceebae..a6aa36d731 100644 --- a/src/x64/codegen-x64.cc +++ b/src/x64/codegen-x64.cc @@ -7317,9 +7317,9 @@ void RegExpExecStub::Generate(MacroAssembler* masm) { // Just jump directly to runtime if native RegExp is not selected at compile // time or if regexp entry in generated code is turned off runtime switch or // at compilation. -#ifndef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); -#else // V8_NATIVE_REGEXP +#else // V8_INTERPRETED_REGEXP if (!FLAG_regexp_entry_native) { __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); return; @@ -7659,7 +7659,7 @@ void RegExpExecStub::Generate(MacroAssembler* masm) { // Do the runtime call to execute the regexp. __ bind(&runtime); __ TailCallRuntime(Runtime::kRegExpExec, 4, 1); -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP } @@ -8262,7 +8262,7 @@ void CEntryStub::GenerateCore(MacroAssembler* masm, // passed in register. #ifdef _WIN64 __ movq(rcx, rax); -#else // ! defined(_WIN64) +#else // _WIN64 __ movq(rdi, rax); #endif __ movq(kScratchRegister, @@ -8296,7 +8296,7 @@ void CEntryStub::GenerateCore(MacroAssembler* masm, __ lea(rdx, Operand(rsp, 4 * kPointerSize)); } -#else // ! defined(_WIN64) +#else // _WIN64 // GCC passes arguments in rdi, rsi, rdx, rcx, r8, r9. __ movq(rdi, r14); // argc. __ movq(rsi, r15); // argv. diff --git a/src/x64/regexp-macro-assembler-x64.cc b/src/x64/regexp-macro-assembler-x64.cc index c998f13500..50b4120a5d 100644 --- a/src/x64/regexp-macro-assembler-x64.cc +++ b/src/x64/regexp-macro-assembler-x64.cc @@ -39,7 +39,7 @@ namespace v8 { namespace internal { -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP /* * This assembler uses the following register assignment convention @@ -1310,6 +1310,6 @@ void RegExpMacroAssemblerX64::LoadCurrentCharacterUnchecked(int cp_offset, #undef __ -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP }} // namespace v8::internal diff --git a/src/x64/regexp-macro-assembler-x64.h b/src/x64/regexp-macro-assembler-x64.h index 6d1396355a..490326971f 100644 --- a/src/x64/regexp-macro-assembler-x64.h +++ b/src/x64/regexp-macro-assembler-x64.h @@ -31,7 +31,7 @@ namespace v8 { namespace internal { -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP class RegExpMacroAssemblerX64: public NativeRegExpMacroAssembler { public: @@ -271,7 +271,7 @@ class RegExpMacroAssemblerX64: public NativeRegExpMacroAssembler { Label stack_overflow_label_; }; -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP }} // namespace v8::internal diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc index 720ab58f19..439261a732 100644 --- a/test/cctest/test-debug.cc +++ b/test/cctest/test-debug.cc @@ -5439,7 +5439,7 @@ TEST(DebugBreakInMessageHandler) { } -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP // Debug event handler which gets the function on the top frame and schedules a // break a number of times. static void DebugEventDebugBreak( @@ -5506,7 +5506,7 @@ TEST(RegExpDebugBreak) { CHECK_EQ(1, break_point_hit_count); CHECK_EQ("f", last_function_hit); } -#endif // V8_NATIVE_REGEXP +#endif // V8_INTERPRETED_REGEXP // Common part of EvalContextData and NestedBreakEventContextData tests. diff --git a/test/cctest/test-regexp.cc b/test/cctest/test-regexp.cc index db312da703..00abab47f8 100644 --- a/test/cctest/test-regexp.cc +++ b/test/cctest/test-regexp.cc @@ -38,7 +38,9 @@ #include "jsregexp.h" #include "regexp-macro-assembler.h" #include "regexp-macro-assembler-irregexp.h" -#ifdef V8_NATIVE_REGEXP +#ifdef V8_INTERPRETED_REGEXP +#include "interpreter-irregexp.h" +#else // V8_INTERPRETED_REGEXP #ifdef V8_TARGET_ARCH_ARM #include "arm/macro-assembler-arm.h" #include "arm/regexp-macro-assembler-arm.h" @@ -51,9 +53,7 @@ #include "ia32/macro-assembler-ia32.h" #include "ia32/regexp-macro-assembler-ia32.h" #endif -#else -#include "interpreter-irregexp.h" -#endif +#endif // V8_INTERPRETED_REGEXP using namespace v8::internal; @@ -645,7 +645,7 @@ TEST(ParsePossessiveRepetition) { // Tests of interpreter. -#ifdef V8_NATIVE_REGEXP +#ifndef V8_INTERPRETED_REGEXP #if V8_TARGET_ARCH_IA32 typedef RegExpMacroAssemblerIA32 ArchRegExpMacroAssembler; @@ -1267,7 +1267,7 @@ TEST(MacroAssemblerNativeLotsOfRegisters) { Top::clear_pending_exception(); } -#else // ! V8_REGEX_NATIVE +#else // V8_INTERPRETED_REGEXP TEST(MacroAssembler) { V8::Initialize(NULL); @@ -1332,7 +1332,7 @@ TEST(MacroAssembler) { CHECK_EQ(42, captures[0]); } -#endif // ! V8_REGEXP_NATIVE +#endif // V8_INTERPRETED_REGEXP TEST(AddInverseToTable) { diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp index 847b4bec39..383564e21a 100644 --- a/tools/gyp/v8.gyp +++ b/tools/gyp/v8.gyp @@ -31,7 +31,6 @@ 'gcc_version%': 'unknown', 'target_arch%': 'ia32', 'v8_use_snapshot%': 'true', - 'v8_regexp%': 'native', }, 'target_defaults': { 'defines': [ @@ -48,13 +47,11 @@ ['target_arch=="ia32"', { 'defines': [ 'V8_TARGET_ARCH_IA32', - 'V8_NATIVE_REGEXP', ], }], ['target_arch=="x64"', { 'defines': [ 'V8_TARGET_ARCH_X64', - 'V8_NATIVE_REGEXP', ], }], ], diff --git a/tools/v8.xcodeproj/project.pbxproj b/tools/v8.xcodeproj/project.pbxproj index 9e4c069370..bdd12d5a2c 100644 --- a/tools/v8.xcodeproj/project.pbxproj +++ b/tools/v8.xcodeproj/project.pbxproj @@ -1650,7 +1650,6 @@ GCC_PREPROCESSOR_DEFINITIONS = ( "$(GCC_PREPROCESSOR_DEFINITIONS)", V8_TARGET_ARCH_IA32, - V8_NATIVE_REGEXP, DEBUG, V8_ENABLE_CHECKS, ENABLE_DEBUGGER_SUPPORT, @@ -1666,7 +1665,6 @@ GCC_PREPROCESSOR_DEFINITIONS = ( "$(GCC_PREPROCESSOR_DEFINITIONS)", V8_TARGET_ARCH_IA32, - V8_NATIVE_REGEXP, NDEBUG, ENABLE_DEBUGGER_SUPPORT, ); @@ -1683,7 +1681,6 @@ "$(GCC_PREPROCESSOR_DEFINITIONS)", ENABLE_DISASSEMBLER, V8_TARGET_ARCH_IA32, - V8_NATIVE_REGEXP, ENABLE_LOGGING_AND_PROFILING, ENABLE_DEBUGGER_SUPPORT, ); @@ -1700,7 +1697,6 @@ GCC_PREPROCESSOR_DEFINITIONS = ( "$(GCC_PREPROCESSOR_DEFINITIONS)", V8_TARGET_ARCH_IA32, - V8_NATIVE_REGEXP, NDEBUG, ENABLE_DEBUGGER_SUPPORT, ); diff --git a/tools/visual_studio/arm.vsprops b/tools/visual_studio/arm.vsprops index 0d6a88875f..98d0f70f25 100644 --- a/tools/visual_studio/arm.vsprops +++ b/tools/visual_studio/arm.vsprops @@ -8,7 +8,7 @@ > diff --git a/tools/visual_studio/ia32.vsprops b/tools/visual_studio/ia32.vsprops index a12f13e746..b574660603 100644 --- a/tools/visual_studio/ia32.vsprops +++ b/tools/visual_studio/ia32.vsprops @@ -8,7 +8,7 @@ >