AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Ship Array grouping

Browse Source 
I2S with 3 LGTMs at
https://groups.google.com/a/chromium.org/g/blink-dev/c/hSnGUOXTXPE/m/IcP21RpVCAAJ

Bug: v8:12499
Change-Id: I495885485297bf8440e653efce45df86a4c8afce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3911376
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83481}
This commit is contained in:
Shu-yu Guo 2022-09-27 13:57:34 -07:00 committed by V8 LUCI CQ
parent 9a2dd870e5
commit e259adc4c7
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/debug/debug-evaluate.cc
View File

@ -574,6 +574,8 @@ DebugInfo::SideEffectState BuiltinGetSideEffectState(Builtin id) {
case Builtin::kArrayPrototypeFlat:
case Builtin::kArrayPrototypeFlatMap:
case Builtin::kArrayPrototypeJoin:
case Builtin::kArrayPrototypeGroup:
case Builtin::kArrayPrototypeGroupToMap:
case Builtin::kArrayPrototypeKeys:
case Builtin::kArrayPrototypeLastIndexOf:
case Builtin::kArrayPrototypeSlice:

4
src/flags/flag-definitions.h
View File

@ -241,7 +241,6 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")
// Features that are complete (but still behind the --harmony flag).
#define HARMONY_STAGED_BASE(V) \
V(harmony_array_grouping, "harmony array grouping") \
V(harmony_rab_gsab, \
"harmony ResizableArrayBuffer / GrowableSharedArrayBuffer") \
V(harmony_change_array_by_copy, "harmony change-Array-by-copy")
@ -258,7 +257,8 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")
V(harmony_atomics, "harmony atomics") \
V(harmony_class_static_blocks, "harmony static initializer blocks") \
V(harmony_array_find_last, "harmony array find last helpers") \
V(harmony_import_assertions, "harmony import assertions")
V(harmony_import_assertions, "harmony import assertions") \
V(harmony_array_grouping, "harmony array grouping")
#ifdef V8_INTL_SUPPORT
#define HARMONY_SHIPPING(V) \

3
test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins.js
View File

@ -77,7 +77,8 @@ function listener(event, exec_state, event_data, data) {
fail(`Array.of(1, 2, 3)`);
var function_param = [
"flatMap", "forEach", "every", "some", "reduce", "reduceRight", "find",
"filter", "map", "findIndex", "findLast", "findLastIndex"
"filter", "map", "findIndex", "findLast", "findLastIndex", "group",
"groupToMap"
];
var fails = ["pop", "push", "reverse", "shift", "unshift", "splice",
"sort", "copyWithin", "fill"];