AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Use more socket ports in debugger agent test.

Browse Source 
This is an attempth to address the flakiness of the test cctest/test-debug/DebuggerAgent on the Mac build-bot.
Review URL: http://codereview.chromium.org/200037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2839 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
sgjesse@chromium.org 2009-09-07 13:24:43 +00:00
parent 223973ef9b
commit e26c1c8d52
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/cctest/test-debug.cc
View File

@ -4503,14 +4503,16 @@ TEST(DebuggerHostDispatch) {
TEST(DebuggerAgent) { TEST(DebuggerAgent) {
// Make sure this port is not used by other tests to allow tests to run in // Make sure these ports is not used by other tests to allow tests to run in
// parallel. // parallel.
const int kPort = 5858; const int kPort1 = 5858;
const int kPort2 = 5857;
const int kPort3 = 5856;
// Make a string with the port number. // Make a string with the port2 number.
const int kPortBufferLen = 6; const int kPortBufferLen = 6;
char port_str[kPortBufferLen]; char port2_str[kPortBufferLen];
OS::SNPrintF(i::Vector<char>(port_str, kPortBufferLen), "%d", kPort); OS::SNPrintF(i::Vector<char>(port2_str, kPortBufferLen), "%d", kPort2);
bool ok; bool ok;
@ -4518,15 +4520,15 @@ TEST(DebuggerAgent) {
i::Socket::Setup(); i::Socket::Setup();
// Test starting and stopping the agent without any client connection. // Test starting and stopping the agent without any client connection.
i::Debugger::StartAgent("test", kPort); i::Debugger::StartAgent("test", kPort1);
i::Debugger::StopAgent(); i::Debugger::StopAgent();
// Test starting the agent, connecting a client and shutting down the agent // Test starting the agent, connecting a client and shutting down the agent
// with the client connected. // with the client connected.
ok = i::Debugger::StartAgent("test", kPort); ok = i::Debugger::StartAgent("test", kPort2);
CHECK(ok); CHECK(ok);
i::Socket* client = i::OS::CreateSocket(); i::Socket* client = i::OS::CreateSocket();
ok = client->Connect("localhost", port_str); ok = client->Connect("localhost", port2_str);
CHECK(ok); CHECK(ok);
i::Debugger::StopAgent(); i::Debugger::StopAgent();
delete client; delete client;
@ -4534,9 +4536,9 @@ TEST(DebuggerAgent) {
// Test starting and stopping the agent with the required port already // Test starting and stopping the agent with the required port already
// occoupied. // occoupied.
i::Socket* server = i::OS::CreateSocket(); i::Socket* server = i::OS::CreateSocket();
server->Bind(kPort); server->Bind(kPort3);
i::Debugger::StartAgent("test", kPort); i::Debugger::StartAgent("test", kPort3);
i::Debugger::StopAgent(); i::Debugger::StopAgent();
delete server; delete server;