AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[build] Fix gn check errors in test/benchmarks/cpp

Browse Source 
Expose third_party/google_benchmark:google_benchmark as a public dep
from third_party/google_benchmark:benchmark_main and a v8_libbase
dependency to empty_benchmark to expose base/macros.h.

Bug: v8:7330
Change-Id: I5205af365da2ac7c35647acff90ed65d831cfa07
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851888
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74217}
This commit is contained in:
Dan Elphick 2021-04-27 10:39:32 +01:00 committed by Commit Bot
parent 2be8412069
commit e3d63e962f
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/benchmarks/cpp/BUILD.gn
View File

@ -25,6 +25,9 @@ if (v8_enable_google_benchmark) {
sources = [ "empty.cc" ]
deps = [ "//third_party/google_benchmark:benchmark_main" ]
deps = [
"//:v8_libbase",
"//third_party/google_benchmark:benchmark_main",
]
}
}

2
third_party/google_benchmark/BUILD.gn vendored
View File

@ -69,6 +69,6 @@ if (v8_enable_google_benchmark) {
source_set("benchmark_main") {
testonly = true
sources = [ "src/src/benchmark_main.cc" ]
deps = [ ":google_benchmark" ]
public_deps = [ ":google_benchmark" ]
}
}