AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] InstructionBlock::PrintBlock

Browse Source 
Debugging helper. Centralized the logic for printing blocks from
InstructionSequence.

A clean(-er) design would be to define an operator<< on a
PrintableInstructionBlock. However, we've discussed moving off those
operators, so it seemed unnecessary to complicate the change.

BUG=

Review URL: https://codereview.chromium.org/1632803003

Cr-Commit-Position: refs/heads/master@{#33505}
This commit is contained in:
mtrofin 2016-01-25 23:00:12 -08:00 committed by Commit bot
parent efcd023e4a
commit e3edb12fc9
2 changed files with 60 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

104
src/compiler/instruction.cc
View File

@ -819,6 +819,62 @@ void InstructionSequence::Print() const {
Print(config);
}
void InstructionSequence::PrintBlock(const RegisterConfiguration* config,
int block_id) const {
OFStream os(stdout);
RpoNumber rpo = RpoNumber::FromInt(block_id);
const InstructionBlock* block = InstructionBlockAt(rpo);
CHECK(block->rpo_number() == rpo);
os << "B" << block->rpo_number();
os << ": AO#" << block->ao_number();
if (block->IsDeferred()) os << " (deferred)";
if (!block->needs_frame()) os << " (no frame)";
if (block->must_construct_frame()) os << " (construct frame)";
if (block->must_deconstruct_frame()) os << " (deconstruct frame)";
if (block->IsLoopHeader()) {
os << " loop blocks: [" << block->rpo_number() << ", " << block->loop_end()
<< ")";
}
os << " instructions: [" << block->code_start() << ", " << block->code_end()
<< ")\n predecessors:";
for (auto pred : block->predecessors()) {
os << " B" << pred.ToInt();
}
os << "\n";
for (auto phi : block->phis()) {
PrintableInstructionOperand printable_op = {config, phi->output()};
os << " phi: " << printable_op << " =";
for (auto input : phi->operands()) {
os << " v" << input;
}
os << "\n";
}
ScopedVector<char> buf(32);
PrintableInstruction printable_instr;
printable_instr.register_configuration_ = config;
for (int j = block->first_instruction_index();
j <= block->last_instruction_index(); j++) {
// TODO(svenpanne) Add some basic formatting to our streams.
SNPrintF(buf, "%5d", j);
printable_instr.instr_ = InstructionAt(j);
os << " " << buf.start() << ": " << printable_instr << "\n";
}
for (auto succ : block->successors()) {
os << " B" << succ.ToInt();
}
os << "\n";
}
void InstructionSequence::PrintBlock(int block_id) const {
const RegisterConfiguration* config =
RegisterConfiguration::ArchDefault(RegisterConfiguration::TURBOFAN);
PrintBlock(config, block_id);
}
FrameStateDescriptor::FrameStateDescriptor(
Zone* zone, FrameStateType type, BailoutId bailout_id,
@ -901,53 +957,7 @@ std::ostream& operator<<(std::ostream& os,
os << "CST#" << i << ": v" << it->first << " = " << it->second << "\n";
}
for (int i = 0; i < code.InstructionBlockCount(); i++) {
RpoNumber rpo = RpoNumber::FromInt(i);
const InstructionBlock* block = code.InstructionBlockAt(rpo);
CHECK(block->rpo_number() == rpo);
os << "B" << block->rpo_number();
os << ": AO#" << block->ao_number();
if (block->IsDeferred()) os << " (deferred)";
if (!block->needs_frame()) os << " (no frame)";
if (block->must_construct_frame()) os << " (construct frame)";
if (block->must_deconstruct_frame()) os << " (deconstruct frame)";
if (block->IsLoopHeader()) {
os << " loop blocks: [" << block->rpo_number() << ", "
<< block->loop_end() << ")";
}
os << " instructions: [" << block->code_start() << ", "
<< block->code_end() << ")\n predecessors:";
for (auto pred : block->predecessors()) {
os << " B" << pred.ToInt();
}
os << "\n";
for (auto phi : block->phis()) {
PrintableInstructionOperand printable_op = {
printable.register_configuration_, phi->output()};
os << " phi: " << printable_op << " =";
for (auto input : phi->operands()) {
os << " v" << input;
}
os << "\n";
}
ScopedVector<char> buf(32);
PrintableInstruction printable_instr;
printable_instr.register_configuration_ = printable.register_configuration_;
for (int j = block->first_instruction_index();
j <= block->last_instruction_index(); j++) {
// TODO(svenpanne) Add some basic formatting to our streams.
SNPrintF(buf, "%5d", j);
printable_instr.instr_ = code.InstructionAt(j);
os << " " << buf.start() << ": " << printable_instr << "\n";
}
for (auto succ : block->successors()) {
os << " B" << succ.ToInt();
}
os << "\n";
printable.sequence_->PrintBlock(printable.register_configuration_, i);
}
return os;
}

3
src/compiler/instruction.h
View File

@ -1323,6 +1323,9 @@ class InstructionSequence final : public ZoneObject {
void Print(const RegisterConfiguration* config) const;
void Print() const;
void PrintBlock(const RegisterConfiguration* config, int block_id) const;
void PrintBlock(int block_id) const;
private:
friend std::ostream& operator<<(std::ostream& os,
const PrintableInstructionSequence& code);