AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[unittests] Remove redundant checkpoint in JSTypedLoweringTest.

Browse Source 
R=bmeurer@chromium.org
TEST=unittests/JSTypedLoweringTest

Review-Url: https://codereview.chromium.org/2694063003
Cr-Commit-Position: refs/heads/master@{#43186}
This commit is contained in:
mstarzinger 2017-02-14 05:36:37 -08:00 committed by Commit bot
parent 8dde6acb74
commit e432f07db4
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/unittests/compiler/js-typed-lowering-unittest.cc
View File

@ -732,14 +732,10 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {
Node* context = UndefinedConstant();
Node* effect = graph()->start();
Node* control = graph()->start();
// TODO(mstarzinger): Once the effect-control-linearizer provides a frame
// state we can get rid of this checkpoint again. The reducer won't care.
Node* checkpoint = graph()->NewNode(common()->Checkpoint(),
EmptyFrameState(), effect, control);
VectorSlotPair feedback;
const Operator* op = javascript()->StoreProperty(language_mode, feedback);
Node* node = graph()->NewNode(op, base, key, value, context,
EmptyFrameState(), checkpoint, control);
EmptyFrameState(), effect, control);
Reduction r = Reduce(node);
Matcher<Node*> offset_matcher =
@ -757,7 +753,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {
BufferAccess(type),
IsPointerConstant(bit_cast<intptr_t>(&backing_store[0])),
offset_matcher, IsNumberConstant(array->byte_length()->Number()),
value_matcher, checkpoint, control));
value_matcher, effect, control));
}
}
}