AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Introduce a third_party_heap test flag

Browse Source 
The flag is useful for disabling tests that are not supported in
the third_party_heap build configuration.

Example usage in the status files:
['third_party_heap', {
  'testname': [SKIP],
}],  # third_party_heap

Bug: v8:11155
Change-Id: I991532bf7cdf89d8c505e4d6cbd7cf9e4d70dd63
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2821960
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73957}
This commit is contained in:
Ulan Degenbaev 2021-04-14 16:09:35 +02:00 committed by Commit Bot
parent 9dbce9abc2
commit e43e1dcd17
4 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
BUILD.gn
View File

@ -333,7 +333,7 @@ if (v8_enable_snapshot_native_code_counters == "") {
} }
if (v8_enable_pointer_compression == "") { if (v8_enable_pointer_compression == "") {
v8_enable_pointer_compression = v8_enable_pointer_compression =
(v8_current_cpu == "arm64" || v8_current_cpu == "x64") v8_current_cpu == "arm64" || v8_current_cpu == "x64"
} }
if (v8_enable_pointer_compression_shared_cage == "") { if (v8_enable_pointer_compression_shared_cage == "") {
v8_enable_pointer_compression_shared_cage = false v8_enable_pointer_compression_shared_cage = false
@ -1918,6 +1918,7 @@ action("v8_dump_build_config") {
"v8_enable_pointer_compression=$v8_enable_pointer_compression", "v8_enable_pointer_compression=$v8_enable_pointer_compression",
"v8_enable_pointer_compression_shared_cage=" + "v8_enable_pointer_compression_shared_cage=" +
"$v8_enable_pointer_compression_shared_cage", "$v8_enable_pointer_compression_shared_cage",
"v8_enable_third_party_heap=$v8_enable_third_party_heap",
"v8_enable_webassembly=$v8_enable_webassembly", "v8_enable_webassembly=$v8_enable_webassembly",
"v8_control_flow_integrity=$v8_control_flow_integrity", "v8_control_flow_integrity=$v8_control_flow_integrity",
"v8_target_cpu=\"$v8_target_cpu\"", "v8_target_cpu=\"$v8_target_cpu\"",

4
tools/testrunner/base_runner.py
View File

@ -190,6 +190,7 @@ class BuildConfig(object):
self.lite_mode = build_config['v8_enable_lite_mode'] self.lite_mode = build_config['v8_enable_lite_mode']
self.pointer_compression = build_config['v8_enable_pointer_compression'] self.pointer_compression = build_config['v8_enable_pointer_compression']
self.pointer_compression_shared_cage = build_config['v8_enable_pointer_compression_shared_cage'] self.pointer_compression_shared_cage = build_config['v8_enable_pointer_compression_shared_cage']
self.third_party_heap = build_config['v8_enable_third_party_heap']
self.webassembly = build_config['v8_enable_webassembly'] self.webassembly = build_config['v8_enable_webassembly']
# Export only for MIPS target # Export only for MIPS target
if self.arch in ['mips', 'mipsel', 'mips64', 'mips64el']: if self.arch in ['mips', 'mipsel', 'mips64', 'mips64el']:
@ -232,6 +233,8 @@ class BuildConfig(object):
detected_options.append('pointer_compression') detected_options.append('pointer_compression')
if self.pointer_compression_shared_cage: if self.pointer_compression_shared_cage:
detected_options.append('pointer_compression_shared_cage') detected_options.append('pointer_compression_shared_cage')
if self.third_party_heap:
detected_options.append('third_party_heap')
if self.webassembly: if self.webassembly:
detected_options.append('webassembly') detected_options.append('webassembly')
@ -684,6 +687,7 @@ class BaseTestRunner(object):
"simulator_run": self.build_config.simulator_run and "simulator_run": self.build_config.simulator_run and
not options.dont_skip_simulator_slow_tests, not options.dont_skip_simulator_slow_tests,
"system": self.target_os, "system": self.target_os,
"third_party_heap": self.build_config.third_party_heap,
"tsan": self.build_config.tsan, "tsan": self.build_config.tsan,
"ubsan_vptr": self.build_config.ubsan_vptr, "ubsan_vptr": self.build_config.ubsan_vptr,
"verify_csa": self.build_config.verify_csa, "verify_csa": self.build_config.verify_csa,

1
tools/unittests/testdata/testroot1/v8_build_config.json vendored
View File

@ -23,5 +23,6 @@
"v8_enable_pointer_compression": true, "v8_enable_pointer_compression": true,
"v8_enable_pointer_compression_shared_cage": true, "v8_enable_pointer_compression_shared_cage": true,
"v8_control_flow_integrity": false, "v8_control_flow_integrity": false,
"v8_enable_third_party_heap": false,
"v8_enable_webassembly": true "v8_enable_webassembly": true
} }

1
tools/unittests/testdata/testroot2/v8_build_config.json vendored
View File

@ -23,5 +23,6 @@
"v8_enable_pointer_compression": false, "v8_enable_pointer_compression": false,
"v8_enable_pointer_compression_shared_cage": false, "v8_enable_pointer_compression_shared_cage": false,
"v8_control_flow_integrity": false, "v8_control_flow_integrity": false,
"v8_enable_third_party_heap": false,
"v8_enable_webassembly": true "v8_enable_webassembly": true
} }