AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Remove default argument for code flags.

Browse Source 
R=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2281863002
Cr-Commit-Position: refs/heads/master@{#38935}
This commit is contained in:
mstarzinger 2016-08-26 02:03:39 -07:00 committed by Commit bot
parent 8ce4475103
commit e53d2acec1
8 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler.h
View File

@ -173,7 +173,7 @@ class CompilationInfo final {
CompilationInfo(ParseInfo* parse_info, Handle<JSFunction> closure);
CompilationInfo(Vector<const char> debug_name, Isolate* isolate, Zone* zone,
Code::Flags code_flags = Code::ComputeFlags(Code::STUB));
Code::Flags code_flags);
~CompilationInfo();
ParseInfo* parse_info() const { return parse_info_; }

2
src/compiler/pipeline.cc
View File

@ -1726,7 +1726,7 @@ bool Pipeline::AllocateRegistersForTesting(const RegisterConfiguration* config,
InstructionSequence* sequence,
bool run_verifier) {
CompilationInfo info(ArrayVector("testing"), sequence->isolate(),
sequence->zone());
sequence->zone(), Code::ComputeFlags(Code::STUB));
ZonePool zone_pool(sequence->isolate()->allocator());
PipelineData data(&zone_pool, &info, sequence);
PipelineImpl pipeline(&data);

3
test/cctest/compiler/codegen-tester.h
View File

@ -67,7 +67,8 @@ class RawMachineAssemblerTester : public HandleAndZoneScope,
Schedule* schedule = this->Export();
CallDescriptor* call_descriptor = this->call_descriptor();
Graph* graph = this->graph();
CompilationInfo info(ArrayVector("testing"), main_isolate(), main_zone());
CompilationInfo info(ArrayVector("testing"), main_isolate(), main_zone(),
Code::ComputeFlags(Code::STUB));
code_ = Pipeline::GenerateCodeForTesting(&info, call_descriptor, graph,
schedule);
}

3
test/cctest/compiler/graph-builder-tester.h
View File

@ -279,7 +279,8 @@ class GraphBuilderTester : public HandleAndZoneScope,
Zone* zone = graph()->zone();
CallDescriptor* desc =
Linkage::GetSimplifiedCDescriptor(zone, this->csig_);
CompilationInfo info(ArrayVector("testing"), main_isolate(), main_zone());
CompilationInfo info(ArrayVector("testing"), main_isolate(), main_zone(),
Code::ComputeFlags(Code::STUB));
code_ = Pipeline::GenerateCodeForTesting(&info, desc, graph());
#ifdef ENABLE_DISASSEMBLER
if (!code_.is_null() && FLAG_print_opt_code) {

2
test/cctest/compiler/test-multiple-return.cc
View File

@ -81,7 +81,7 @@ TEST(ReturnThreeValues) {
m.Return(add, sub, mul);
CompilationInfo info(ArrayVector("testing"), handles.main_isolate(),
handles.main_zone());
handles.main_zone(), Code::ComputeFlags(Code::STUB));
Handle<Code> code =
Pipeline::GenerateCodeForTesting(&info, desc, m.graph(), m.Export());
#ifdef ENABLE_DISASSEMBLER

3
test/cctest/compiler/test-run-native-calls.cc
View File

@ -242,7 +242,8 @@ class Int32Signature : public MachineSignature {
Handle<Code> CompileGraph(const char* name, CallDescriptor* desc, Graph* graph,
Schedule* schedule = nullptr) {
Isolate* isolate = CcTest::InitIsolateOnce();
CompilationInfo info(ArrayVector("testing"), isolate, graph->zone());
CompilationInfo info(ArrayVector("testing"), isolate, graph->zone(),
Code::ComputeFlags(Code::STUB));
Handle<Code> code =
Pipeline::GenerateCodeForTesting(&info, desc, graph, schedule);
CHECK(!code.is_null());

15
test/cctest/test-field-type-tracking.cc
View File

@ -603,7 +603,8 @@ static void TestGeneralizeRepresentation(
// Create new maps by generalizing representation of propX field.
Handle<Map> field_owner(map->FindFieldOwner(property_index), isolate);
CompilationInfo info(ArrayVector("testing"), isolate, &zone);
CompilationInfo info(ArrayVector("testing"), isolate, &zone,
Code::ComputeFlags(Code::STUB));
CHECK(!info.dependencies()->HasAborted());
info.dependencies()->AssumeFieldType(field_owner);
@ -982,7 +983,8 @@ static void TestReconfigureDataFieldAttribute_GeneralizeRepresentation(
Zone zone(isolate->allocator());
Handle<Map> field_owner(map->FindFieldOwner(kSplitProp), isolate);
CompilationInfo info(ArrayVector("testing"), isolate, &zone);
CompilationInfo info(ArrayVector("testing"), isolate, &zone,
Code::ComputeFlags(Code::STUB));
CHECK(!info.dependencies()->HasAborted());
info.dependencies()->AssumeFieldType(field_owner);
@ -1067,7 +1069,8 @@ static void TestReconfigureDataFieldAttribute_GeneralizeRepresentationTrivial(
Zone zone(isolate->allocator());
Handle<Map> field_owner(map->FindFieldOwner(kSplitProp), isolate);
CompilationInfo info(ArrayVector("testing"), isolate, &zone);
CompilationInfo info(ArrayVector("testing"), isolate, &zone,
Code::ComputeFlags(Code::STUB));
CHECK(!info.dependencies()->HasAborted());
info.dependencies()->AssumeFieldType(field_owner);
@ -1598,7 +1601,8 @@ static void TestReconfigureElementsKind_GeneralizeRepresentation(
Zone zone(isolate->allocator());
Handle<Map> field_owner(map->FindFieldOwner(kDiffProp), isolate);
CompilationInfo info(ArrayVector("testing"), isolate, &zone);
CompilationInfo info(ArrayVector("testing"), isolate, &zone,
Code::ComputeFlags(Code::STUB));
CHECK(!info.dependencies()->HasAborted());
info.dependencies()->AssumeFieldType(field_owner);
@ -1691,7 +1695,8 @@ static void TestReconfigureElementsKind_GeneralizeRepresentationTrivial(
Zone zone(isolate->allocator());
Handle<Map> field_owner(map->FindFieldOwner(kDiffProp), isolate);
CompilationInfo info(ArrayVector("testing"), isolate, &zone);
CompilationInfo info(ArrayVector("testing"), isolate, &zone,
Code::ComputeFlags(Code::STUB));
CHECK(!info.dependencies()->HasAborted());
info.dependencies()->AssumeFieldType(field_owner);

3
test/cctest/wasm/wasm-run-utils.h
View File

@ -415,7 +415,8 @@ class WasmFunctionWrapper : public HandleAndZoneScope,
r.LowerGraph();
}
CompilationInfo info(ArrayVector("testing"), isolate, graph()->zone());
CompilationInfo info(ArrayVector("testing"), isolate, graph()->zone(),
Code::ComputeFlags(Code::STUB));
code_ =
Pipeline::GenerateCodeForTesting(&info, descriptor, graph(), nullptr);
CHECK(!code_.is_null());