AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[API] Deprecate OOMErrorCallback

Browse Source 
Deprecate the OOMErrorCallback such that we can add a new parameter for
OOM details.

R=mlippautz@chromium.org

Bug: chromium:1323177
Change-Id: I72c931ad0d1b75cda46e8815387098acbe091c68
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632106
Reviewed-by: Lutz Vahl <vahl@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80453}
This commit is contained in:
Clemens Backes 2022-05-06 17:50:26 +02:00 committed by V8 LUCI CQ
parent 338c12b3af
commit e57f4bb3fc
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/v8-callbacks.h
View File

@ -220,7 +220,7 @@ using LegacyOOMErrorCallback = void (*)(const char* location, bool is_heap_oom);
// TODO(chromium:1323177): Add a parameter for details, once this is deprecated
// for at least one branch.
using OOMErrorCallback V8_DEPRECATE_SOON(
using OOMErrorCallback V8_DEPRECATED(
"Use LegacyOOMErrorCallback; OOMErrorCallback will be changed "
"(https://crbug.com/1323177)") = void (*)(const char* location,
bool is_heap_oom);

2
include/v8-isolate.h
View File

@ -287,7 +287,7 @@ class V8_EXPORT Isolate {
*/
FatalErrorCallback fatal_error_callback = nullptr;
LegacyOOMErrorCallback legacy_oom_error_callback = nullptr;
V8_DEPRECATE_SOON(
V8_DEPRECATED(
"Use legacy_oom_error_callback; OOMErrorCallback will be changed soon "
"(https://crbug.com/1323177)")
OOMErrorCallback oom_error_callback = nullptr;