AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[js-perf-test] Add more WeakMap perf tests"

Browse Source 
This reverts commit 62a8bdca52.

Reason for revert: Test times out on atom

Original change's description:
> [js-perf-test] Add more WeakMap perf tests
> 
> Change-Id: I46eb94e58fc4da55cb1b2adb9ffdbb09e5e33a5d
> Bug: v8:8557
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530800
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60326}

TBR=ulan@chromium.org,jarin@chromium.org,sigurds@chromium.org

Change-Id: I88ae85bea2ad04db11137a602bd3d8ee6978fa04
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8557
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532061
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60353}
This commit is contained in:
Sigurd Schneider 2019-03-20 09:51:12 +00:00 committed by Commit Bot
parent e8ba632d3a
commit e58c9d924d
2 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/js-perf-test/Collections/weakmap.js
View File

@ -19,11 +19,6 @@ var MapBenchmark = new BenchmarkSuite('WeakMapSetGet-Large', [1e7], [
WeakMapSetupBaseLarge, WeakMapTearDown),
]);
var MapBenchmark = new BenchmarkSuite('WeakMapSet-Huge', [1e8], [
new Benchmark('Set-Get', false, false, 0, WeakMapSetHuge,
WeakMapSetupBaseLarge, WeakMapTearDown),
]);
var MapBenchmark = new BenchmarkSuite('WeakMap-Constructor', [1000], [
new Benchmark('Constructor', false, false, 0, WeakMapConstructor, SetupObjectKeyValuePairs,
WeakMapTearDown),
@ -97,7 +92,7 @@ function WeakMapGet() {
function WeakMapDelete() {
// This is run more than once per setup so we will end up deleting items
// more than once. Therefore, we do not check the return value of delete.
// more than once. Therefore, we do not the return value of delete.
for (var i = 0; i < N; i++) {
wm.delete(keys[i]);
}
@ -118,15 +113,3 @@ function WeakMapSetGetLarge() {
}
}
}
function WeakMapSetHuge() {
function Foo(i) {
this.x = i;
}
const N = 50 * 1000;
let obj;
for (let i = 0; i < N; i++) {
obj = new Foo(i); // Make sure we do not scalar-replace the object.
wm.set(obj, 1);
}
}

2
test/js-perf-test/JSTests.json
View File

@ -380,8 +380,6 @@
{"name": "Set-Iterator"},
{"name": "WeakMap"},
{"name": "WeakMap-Constructor"},
{"name": "WeakMapSetGet-Large"},
{"name": "WeakMapSet-Huge"},
{"name": "WeakSet"},
{"name": "WeakSet-Constructor"}
]