AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[gc][static-roots] Fix more accesses to r/o markbits"

Browse Source 
This reverts commit c5ff664bc8.

Reason for revert: Initial CL(https://chromium-review.googlesource.com/c/v8/v8/+/4212397) with InReadOnlySpace() was reverted.

Original change's description:
> [gc][static-roots] Fix more accesses to r/o markbits
>
> Two overlooked ones in marking barrier and cppgc.
>
> Fixes blink tests.
>
> Bug: v8:13717
> Change-Id: I2c8beb0db1bcc38ae37a058f02da448dae9c7207
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4224152
> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
> Auto-Submit: Olivier Flückiger <olivf@chromium.org>
> Commit-Queue: Olivier Flückiger <olivf@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#85692}

Bug: v8:13717
Change-Id: I2e6c45251c28d5de2580833a0cdcfe8630046803
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4226004
Commit-Queue: Ilya Rezvov <irezvov@chromium.org>
Owners-Override: Ilya Rezvov <irezvov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ilya Rezvov <irezvov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85696}
This commit is contained in:
Ilya Rezvov 2023-02-06 21:24:07 +00:00 committed by V8 LUCI CQ
parent a37302d8f7
commit e6353fe071
3 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/heap/cppgc-js/unified-heap-marking-state-inl.h
View File

@ -46,7 +46,6 @@ void UnifiedHeapMarkingState::MarkAndPush(
return; return;
} }
HeapObject heap_object = HeapObject::cast(object); HeapObject heap_object = HeapObject::cast(object);
if (heap_object.InReadOnlySpace()) return;
if (marking_state_->WhiteToGrey(heap_object)) { if (marking_state_->WhiteToGrey(heap_object)) {
local_marking_worklist_->Push(heap_object); local_marking_worklist_->Push(heap_object);
} }

1
src/heap/marking-barrier-inl.h
View File

@ -70,7 +70,6 @@ void MarkingBarrier::MarkValueShared(HeapObject value) {
} }
void MarkingBarrier::MarkValueLocal(HeapObject value) { void MarkingBarrier::MarkValueLocal(HeapObject value) {
DCHECK(!value.InReadOnlySpace());
if (is_minor()) { if (is_minor()) {
// We do not need to insert into RememberedSet<OLD_TO_NEW> here because the // We do not need to insert into RememberedSet<OLD_TO_NEW> here because the
// C++ marking barrier already does this for us. // C++ marking barrier already does this for us.

2
src/heap/marking-barrier.cc
View File

@ -60,7 +60,7 @@ void MarkingBarrier::WriteWithoutHost(HeapObject value) {
return; return;
} }
} }
if (value.InReadOnlySpace()) return;
MarkValueLocal(value); MarkValueLocal(value);
} }